Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): update type exports to prevent missing exports warnings #3662

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

joshblack
Copy link
Member

We were getting missing import warnings in both Gatsby and in Webpack due to the way types were being exported in component entrypoints. This PR updates the way we export types to use the explicit export type syntax to avoid this missing export warning.

@joshblack joshblack requested review from a team and siddharthkp August 23, 2023 20:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: 6c90f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 103.93 KB (0%)
dist/browser.umd.js 104.47 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants