Toggle switch a11y take3 #3510
Merged
Toggle switch a11y take3 #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Address ToggleSwitch a11y feedback * Remove unused import * Add changeset * Fix tests
🦋 Changeset detectedLatest commit: 1087281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
@camertron I assume with merging main after #3520 resolves the failing tests at dotcom?
|
@broccolinisoup yes, that's correct 👍 |
Merged
broccolinisoup
added a commit
that referenced
this pull request
Jul 21, 2023
This reverts commit bdbcfd1.
broccolinisoup
added a commit
that referenced
this pull request
Jul 25, 2023
This reverts commit 5f94786.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…3545) * Add deprecated notice and run console warn only in DEV * run when the env is not test * Revert "Toggle switch a11y take3 (#3510)" This reverts commit bdbcfd1. * take the list changes back for underlinenav * lint and test fix * Add back "Toggle switch a11y take3 (#3510)" This reverts commit 5f94786. * Revert "take the list changes back for underlinenav" This reverts commit 843e304. * fix after revert commit * remove console warning and update docs and changeset * fix changeset and update prop docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the accessibility feedback for the ToggleSwitch component, outlined in this issue: https://github.com/github/primer/issues/1867. It is a re-submission of #3251 and #3433 which had to be reverted. See #3429 for details.
Namely it:
role=switchfrom the button.aria-pressedin favor ofaria-checked.Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.