-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pullQueued state to StateLabel #3244
Conversation
🦋 Changeset detectedLatest commit: 1b976ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening up this PR! 🥳 Just left a small question as a comment 👀
Co-authored-by: Josh Black <joshblack@github.com>
🔥 great work @Bestra! |
Just wanted to request your review @danielguillan from the design side for this change 👀 Let me know if there would be someone better to bring in! Just was using the first responder rotation this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for putting this together 🥳 Just needs a +1 from design and should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I'm adding @lukasoppermann to double check as he's been working on Primer Labels recently.
Hey, thanks for bringing this up. One question, is there any specific reasoning behind the color? Or was it mainly that the other ones are used already? |
@lukasoppermann Looking back through the issue history I think we're attempting to match the merge queue icon color from |
Adds the
pullQueued
state to theStateLabel
component.Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.