Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pullQueued state to StateLabel #3244

Merged
merged 4 commits into from
May 4, 2023

Conversation

Bestra
Copy link
Contributor

@Bestra Bestra commented May 1, 2023

Adds the pullQueued state to the StateLabel component.

Screenshots

image

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2023

🦋 Changeset detected

Latest commit: 1b976ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Bestra Bestra temporarily deployed to github-pages May 1, 2023 19:03 — with GitHub Actions Inactive
@Bestra Bestra temporarily deployed to github-pages May 1, 2023 19:14 — with GitHub Actions Inactive
@Bestra Bestra temporarily deployed to github-pages May 1, 2023 19:50 — with GitHub Actions Inactive
@Bestra Bestra marked this pull request as ready for review May 1, 2023 20:05
@Bestra Bestra requested review from a team and josepmartins May 1, 2023 20:05
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening up this PR! 🥳 Just left a small question as a comment 👀

docs/content/StateLabel.mdx Outdated Show resolved Hide resolved
Co-authored-by: Josh Black <joshblack@github.com>
@talum
Copy link
Contributor

talum commented May 2, 2023

🔥 great work @Bestra!

@joshblack
Copy link
Member

Just wanted to request your review @danielguillan from the design side for this change 👀 Let me know if there would be someone better to bring in! Just was using the first responder rotation this week.

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for putting this together 🥳 Just needs a +1 from design and should be good to go.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm adding @lukasoppermann to double check as he's been working on Primer Labels recently.

@lukasoppermann
Copy link
Contributor

Hey, thanks for bringing this up. One question, is there any specific reasoning behind the color? Or was it mainly that the other ones are used already?

@Bestra
Copy link
Contributor Author

Bestra commented May 3, 2023

One question, is there any specific reasoning behind the color?

@lukasoppermann Looking back through the issue history I think we're attempting to match the merge queue icon color from
https://github.com/github/primer/issues/295, but I can't speak to the rationale beyond that.

@joshblack joshblack added this pull request to the merge queue May 4, 2023
Merged via the queue into primer:main with commit 42a78c1 May 4, 2023
@primer-css primer-css mentioned this pull request May 4, 2023
@Bestra Bestra deleted the bestra/add-queued-statelabel branch May 5, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants