Skip to content

Use SSR-compatible slot implementation in FormControl #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2023

Conversation

colebemis
Copy link
Contributor

Swaps out the underlying slots implementation for FormControl.

See #1690 for more context.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

🦋 Changeset detected

Latest commit: 4ddb79c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.42 KB (-0.05% 🔽)
dist/browser.umd.js 95.99 KB (-0.07% 🔽)

@colebemis colebemis temporarily deployed to github-pages April 11, 2023 02:06 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3149 April 11, 2023 02:06 Inactive
@colebemis colebemis temporarily deployed to github-pages April 11, 2023 02:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3149 April 11, 2023 02:16 Inactive
@colebemis colebemis added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit 4c2d121 Apr 11, 2023
@colebemis colebemis deleted the formcontrol-slots branch April 11, 2023 23:12
This was referenced Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants