Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use camelCase for tooltipDirection prop #3101

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Use camelCase for tooltipDirection prop #3101

merged 2 commits into from
Mar 30, 2023

Conversation

colebemis
Copy link
Contributor

Describe your changes here.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@colebemis colebemis requested review from a team and siddharthkp March 30, 2023 23:02
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

⚠️ No Changeset found

Latest commit: 8b4bcb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 97.02 KB (-0.01% 🔽)
dist/browser.umd.js 97.56 KB (-0.01% 🔽)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@colebemis colebemis added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 81967be Mar 30, 2023
@colebemis colebemis deleted the tooltip-dir branch March 30, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants