Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export useResponsiveValue in index.ts #3090

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Conversation

kendallgassner
Copy link
Contributor

Describe your changes here.

Exposing useResponsiveValue in index.ts

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@kendallgassner kendallgassner requested review from a team and colebemis March 29, 2023 22:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

🦋 Changeset detected

Latest commit: 77c6136

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.05 KB (+0.02% 🔺)
dist/browser.umd.js 95.59 KB (+0.02% 🔺)

@kendallgassner kendallgassner temporarily deployed to github-pages March 29, 2023 22:29 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3090 March 29, 2023 22:29 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like you just need to update the snapshot test (npm test -- -u)

@kendallgassner kendallgassner temporarily deployed to github-pages March 31, 2023 20:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3090 March 31, 2023 20:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants