Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add story source code to components.json #2948

Merged
merged 18 commits into from
Feb 28, 2023
Merged

Add story source code to components.json #2948

merged 18 commits into from
Feb 28, 2023

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Feb 28, 2023 •
edited
Loading

This PR adds source code for storybook stories to the generated components.json file so that we can display that source code in the storybook embeds on primer.style/design (example: https://primer.style/design/components/tree-view/react#examples)

CleanShot 2023-02-27 at 19 26 01@2x

Before/After

generated/component.json:

CleanShot 2023-02-27 at 19 27 59@2x

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c4e9346

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.49 KB (0%)
dist/browser.umd.js 95.07 KB (0%)

@colebemis colebemis marked this pull request as ready for review February 28, 2023 02:30
@colebemis colebemis requested review from a team, josepmartins and joshblack February 28, 2023 02:30
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 02:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 02:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 02:37 Inactive
@primer primer bot temporarily deployed to github-pages February 28, 2023 02:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 02:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 02:40 Inactive
@colebemis colebemis changed the title Add story source code to component.json Add story source code to components.json Feb 28, 2023
@primer primer bot temporarily deployed to github-pages February 28, 2023 03:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 03:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 03:15 Inactive
@colebemis colebemis mentioned this pull request Feb 28, 2023
Merged
langermank
langermank approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such an exciting improvement! 🚀

joshblack
joshblack approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! 🥳 Just left a comment for the leading ; but looks amazing 🔥

@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 16:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 16:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 16:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2948 February 28, 2023 16:58 Inactive
@colebemis colebemis added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 0215c96 Feb 28, 2023
@colebemis colebemis deleted the story-source-code branch February 28, 2023 17:21
@primer-css primer-css mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack joshblack approved these changes

@josepmartins josepmartins Awaiting requested review from josepmartins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colebemis @joshblack @langermank