Skip to content

2841 use githubaxe config as config for axe #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 24, 2023
Merged

2841 use githubaxe config as config for axe #2932

merged 11 commits into from
Feb 24, 2023

Conversation

agreenberry
Copy link
Contributor

@agreenberry agreenberry commented Feb 23, 2023 •
edited
Loading

This is a stop gap to close out #2841. There were issues with integrating @axe-github with@playwright/test and so, for the sake of time, energy, and priorities, @joshblack and @erinnachen gave the okay that we can just manually add the rules/checks needed for now.

Screenshots

When looking for axe violations with Playwright, we are now using the manually added rules and checks that are generated from @axe-github https://www.npmjs.com/package/@github/axe-github

image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@agreenberry agreenberry linked an issue Feb 23, 2023 that may be closed by this pull request
Use @github/axe-config as config for axe #2841
Closed
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8cb90aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.28 KB (0%)
dist/browser.umd.js 94.86 KB (0%)

@agreenberry agreenberry temporarily deployed to github-pages February 23, 2023 17:53 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 23, 2023 17:53 Inactive
@agreenberry agreenberry temporarily deployed to github-pages February 23, 2023 21:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 23, 2023 21:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 23, 2023 21:35 Inactive
@agreenberry agreenberry marked this pull request as ready for review February 23, 2023 22:35
@agreenberry agreenberry requested review from a team and josepmartins February 23, 2023 22:35
@agreenberry agreenberry temporarily deployed to github-pages February 23, 2023 22:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 23, 2023 22:36 Inactive
@agreenberry agreenberry temporarily deployed to github-pages February 23, 2023 23:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 23, 2023 23:37 Inactive
joshblack
joshblack requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this 🙏 Just left a comment for the changeset but should be good after that 👍

@joshblack joshblack added the skip changeset This change does not need a changelog label Feb 24, 2023
joshblack
joshblack approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@agreenberry agreenberry temporarily deployed to github-pages February 24, 2023 17:04 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 24, 2023 17:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2932 February 24, 2023 17:06 Inactive
@agreenberry agreenberry added this pull request to the merge queue Feb 24, 2023
@agreenberry agreenberry removed this pull request from the merge queue due to a manual request Feb 24, 2023
@agreenberry agreenberry temporarily deployed to github-pages February 24, 2023 22:58 — with GitHub Actions Inactive
@agreenberry agreenberry added this pull request to the merge queue Feb 24, 2023
Merged via the queue into main with commit bf16dea Feb 24, 2023
@agreenberry agreenberry deleted the 2841-use-githubaxe-config-as-config-for-axe branch February 24, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@josepmartins josepmartins Awaiting requested review from josepmartins

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @github/axe-config as config for axe
2 participants
@agreenberry @joshblack