Skip to content

Refactor components and stories #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from

Conversation

agreenberry
Copy link
Contributor

Describe your changes here.

Match the conventions listed in https://github.com/primer/react/blob/main/contributor-docs/adrs/adr-XXX-file-structure.md

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2023

🦋 Changeset detected

Latest commit: b6a9522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.61 KB (+0.02% 🔺)
dist/browser.umd.js 90.22 KB (-0.01% 🔽)

@colebemis colebemis self-requested a review February 2, 2023 21:36
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this up into smaller PRs? It scares me to merge so many changes at once.

@agreenberry
Copy link
Contributor Author

This PR is too big. If anything comes of this, it would need to be in several smaller PRs.

@jonrohan jonrohan deleted the refactor-components-and-stories branch May 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants