UnderlineNav2: Update total height of the navigation to 48px
#2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d24e04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
requested review from
a team,
colebemis,
danielguillan and
langermank
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@danielguillan Could I please get your review on this? 🙌🏻 |
langermank
approved these changes
Feb 7, 2023
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Closes #2827
UnderlineNav's total navigation height is currently
45pxbut it should be48pxand this PR updates the height.Screenshots
Please see the playwright test pngs on the files diff to see the visual difference on the height.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.