[UnderlineNav2]: Always show at least 2 items in the overflow menu (A11y remediations) #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e139a04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
requested review from
a team,
siddharthkp,
danielguillan and
ericwbailey
|
👋🏼 @danielguillan Displaying at least two items in the |
ericwbailey
approved these changes
Oct 24, 2022
colebemis
approved these changes
Oct 25, 2022
broccolinisoup
force-pushed
the
introduce-disclosure-pattern
branch
from
ef2cb54
to
2b1a8d2
Compare
broccolinisoup
force-pushed
the
two-items-in-menu
branch
from
98465b9
to
e139a04
Compare
|
@danielguillan I merged this PR into the feature branch. You can review the implementation including the rest of the a11y sign-off feedback in this PR |
broccolinisoup
added a commit
that referenced
this pull request
Oct 26, 2022
…11y remediations) (#2471) * Display at least two items in the menu * add changeset
broccolinisoup
added a commit
that referenced
this pull request
Oct 26, 2022
* Disclosure pattern implementation * use token name for colours instead of accessing them from theme Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * code review feedback <3 * [UnderlineNav2]: Always show at least 2 items in the overflow menu (A11y remediations) (#2471) * Display at least two items in the menu * add changeset * [UnderlineNav2]: Add visually hidden heading where `aria-label` is present (#2470) * Add visually hidden heading * add changeset and a test * append 'navigation' to the aria-label string * use prop for 'as' * add changeset Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the accessibility sign-off review feedback (ref: comment), we need to make sure to have at least two items in the
Moremenu when there is overflow. See @ericwbailey 's comment below for reasoning behindStorybook test link: https://primer-9af4b5b990-13348165.drafts.github.io/storybook/?path=/story/components-underlinenav--default-nav
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.