ActionMenu: Fix keyboard navigation for ActionMenu inside Overlay

[siddharthkp]

Notes for reviewer:

I had removed focus trap in #2024 as redundant, because we handle keyboard interactions already. released in v35.6.0

I found a use case where focus trap can't be removed - when ActionMenu is inside a focus trap (like AnchoredOverlay), keyboard navigation of ActionMenu would get hijacked by the parent focus trap. Re-introducing focus trap solves this issue.

Is this change safe?

Tested this change in memex (https://github.com/github/memex/pull/11620), one failed test (expected, caused by bringing back focus trap 👍).

Are there any edge cases?

Known issue: Pressing Tab on an open menu closes the menu and put the focus back on the anchor instead of the next element because it "returns" to the parent focus trap. I didn't find a way to communicate to the parent focus trap to move focus to the next tabbable element :(

Unrelated change

Consumer tests are failing on this PR, any ideas?

---

Details:

Fixes keyboard navigation for the menu in memex project settings (private project)

before:

before-2266.mov

after:

after-2266.mov

---

Accessibility

There is overlap between keyboard navigation of Overlay's focus trap and Menu's focus trap inside it, not sure what the ideal behavior is.

Asked on the accessibility channel (private github slack), For overlays with forms, we should use Tabs bindings not ArrowKeys (memex already does that, so we're good!)

video

tabs-focus-trap.mov

Long term: we should look in to the defaults and recommended component for overlays. AnchoredOverlay is pretty low level, we need to improve Dialog (with focus trap with Tab bindings) and make that the recommended component.

---

scenarios & video for a11y issues

Default scenario: AnchoredOverlay's focus trap has bindings for ArrowKeys (not Tabs), (see story for running example)

https://github.slack.com/archives/C0FSWLQ0Y/p1661507974126029

1. Pressing ArrowDown on menu button will not open the menu, but move focus to the next element
2. Pressing Tab on an open menu will close the menu and put the focus back on the anchor instead of the next element (the parent Overlay's focus trap is using ArrowKeys for navigation, not Tab)

Customised scenario in memex: AnchoredOverlay's focus trap has bindings for Tabs,

1. Pressing Tab on an open menu will close the menu and put the focus back on the anchor instead of the next element

tabs-focus-trap.mov

[changeset-bot]

🦋 Changeset detected

Latest commit: 062ff87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	76.25 KB (-0.02% 🔽)
dist/browser.umd.js	76.86 KB (-0.02% 🔽)