Rename stickyTop->offsetHeader and improve docs #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4564242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
6 tasks
broccolinisoup
commented
Aug 24, 2022
siddharthkp
reviewed
Aug 26, 2022
siddharthkp
reviewed
Aug 26, 2022
docs/content/PageLayout.mdx
Outdated
| type="number | string" | ||
| defaultValue="0" | ||
| description="Use stickyTop to push the sticky pane down to make room for a sticky header if necessary. Use the type `string` to specify the height with a unit i.e. 5rem; otherwise the type `number` will be taken as px." | ||
| description="Use offsetTop along with the sticky prop to push the sticky pane down to make room for a sticky header if necessary. Use the type `string` to specify the height with a unit i.e. 5rem; otherwise the type `number` will be taken as px." |
siddharthkp
requested changes
Aug 26, 2022
colebemis
reviewed
Aug 26, 2022
colebemis
reviewed
Aug 26, 2022
colebemis
reviewed
Aug 26, 2022
broccolinisoup
changed the title
siddharthkp
approved these changes
Sep 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
stickyToptooffsetHeadersuggested by @siddharthkp .@colebemis @siddharthkp Just creating a PR to get the feeling with the improved docs. Let me know what you think
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.