Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutocompleteContext to the Autocomplete component's exports #2115

Closed

Conversation

willglas
Copy link
Contributor

@willglas willglas commented Jun 6, 2022

Added AutocompleteContext to the Autocomplete component's exports. This allows consumers to customize the Autocomplete component's behavior to a much larger degree.

Screenshots

No visual changes.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

I wasn't sure if updating documentation was necessary, let me know if that's required for this change to go in.

@willglas willglas requested review from a team and siddharthkp June 6, 2022 16:00
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: 5b12b0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@willglas
Copy link
Contributor Author

willglas commented Jun 8, 2022

@mperrotti it looks like you might need to kick off some CI?

@mperrotti
Copy link
Contributor

@colebemis - the new CI issue with package-lock.json is happening.

How did you get it to work last time?

Here's what I've tried:

  • Re-running the checks
  • rm -rf node_modules && npm cache clear -f && npm i on this branch after merging main

cc @siddharthkp since you're not as busy with the design summit.

@mperrotti
Copy link
Contributor

@willglas - Could you open a PR as a branch directly off of this repo? Org tokens aren't propagating or being respected, so deployments aren't working for PRs from a forked repo.

@willglas
Copy link
Contributor Author

willglas commented Jun 24, 2022

@mperrotti I don't have permissions to push branches directly to this repo. Do you know how I can get it?

@mperrotti
Copy link
Contributor

Hey @willglas - I’m looking into this now. Worst-case scenario, I’ll cherry-pick your commits onto a new branch and open a PR

@mperrotti
Copy link
Contributor

@willglas - you should have received an invite

@willglas
Copy link
Contributor Author

@mperrotti thanks! here's the new PR: #2153

@willglas willglas closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants