Skip to content

Create contributing-docs/debt.md #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented May 12, 2022

wip

  • create-slots needs a double render which would create UI jank with server side rendering as visuals & descriptions slots are not filled until hydration on client
  • primitives are resolved to hex values instead of css variables which creates flash of incorrect theme
  • styled-components + styled-system performance adds up over time as components build up

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2022

⚠️ No Changeset found

Latest commit: f8d7389

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp changed the title Create debt.md Create contributing-docs/debt.md May 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 65.79 KB (0%)
dist/browser.umd.js 66.08 KB (0%)

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label May 12, 2022
@siddharthkp siddharthkp self-assigned this May 12, 2022
@siddharthkp siddharthkp temporarily deployed to github-pages May 12, 2022 10:19 Inactive
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 11, 2022
@joshblack joshblack deleted the siddharthkp/debt-md branch January 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant