Skip to content

Fixes for v35 #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Fixes for v35 #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4dde4d
fix ActioMenu story
rezrah Mar 8, 2022
bd10750
backfill missing exports in root index
rezrah Mar 8, 2022
50e01bb
fix package-lock
rezrah Mar 8, 2022
0ee2945
add changeset
rezrah Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .changeset/twenty-weeks-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
'@primer/react': patch
---

Surfaced the following components and hooks from the root index:

- Portal
- AnchoredOverlay
- useFocusTrap
- useFocusZone (and types)
- sx (and types)
- ConfirmationDialogProps

These exports can now be imported from the root index, rather than from their nested subfolders.

E.g.

```diff
- import { ConfirmationDialogProps } from '@primer/react/lib-esm/Dialog/ConfirmationDialog';
+ import { ConfirmationDialogProps } from '@primer/react';
```
5 changes: 1 addition & 4 deletions docs/content/system-props.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: System Props
---

import {PropsList, COMMON, LAYOUT, BORDER, TYPOGRAPHY, FLEX, POSITION, GRID} from '../components'
import {PropsList, COMMON, LAYOUT, BORDER, TYPOGRAPHY} from '../components'

<Note variant="warning">

Expand Down Expand Up @@ -32,6 +32,3 @@ For example, if you wanted to add some flex utilities to the `Text` component, y
| `TYPOGRAPHY` | <PropsList systemProps={TYPOGRAPHY}/> | [styled-system typography docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#typography) |
| `BORDER` | <PropsList systemProps={BORDER}/> | [styled-system border docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#border) |
| `LAYOUT` | <PropsList systemProps={LAYOUT}/> | [styled-system layout docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#layout) <br/> [styled-system misc docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#misc) |
| `POSITION` | <PropsList systemProps={POSITION}/> | [styled-system position docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#position) |
| `FLEX` | <PropsList systemProps={FLEX}/> | [styled-system flexbox docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#flexbox) |
| `GRID` | <PropsList systemProps={GRID}/> | [styled-system grid docs](https://github.com/styled-system/styled-system/blob/master/docs/table.md#grid-layout) |
Loading