You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
All tests are passing except for the checkStoriesForAxeViolations tests, which require the stories themselves.
Now that the root and stories/ directories have separate package.json manifests and node_modules, it appears that we may have two separate instances of React installed. Temporarily, this can be resolved by rm -r-ing the stories/node_modules directory, which wipes out the additional React package installation, but I'm not sure what a permanent fix looks like, yet.
👋 I know this isn't done yet, but I wanted to mention that this approach would move us away from the file structure ADR that @jfuchs proposed last quarter. Not a dealbreaker but something to consider.
@colebemis I don't think we have a choice, unfortunately, unless we want to continue having Primer React ship non-compiling types in its build output. This happens just because those types are in our node_modules directory when we compile.
The only other solution I might try is to restrict the typeRoots in tsconfig.build.json, but it'll mean listing each build dependency's node_modules types path specifically.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jclem
force-pushed
the
extract-stories
branch
from
🚨 🏗️ WIP: Work in progress 🚧 🚨
Closes #1849 by extracting Storybook files and configuration to the stories/ directory.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.