You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm proposing we deprecate the current Label, StateLabel, and possibly CounterLabel components and introduce a new one where we support the design work @auareyou has been doing. Design issue link: https://github.com/github/primer/issues/192
The current Label component would require breaking changes in order to be compatible with color modes, so it would be impossible to get it to Beta.
TODO:
Get the React documentation to render the new Label and StateLabel components instead of the old ones (help wanted)
Review the latest designs for labels to confirm I'm still going in the right direction
Screenshots
Coming soon
Merge checklist
Added/updated tests
Added/updated documentation
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Closing this PR to open a new one that's smaller in scope.
Instead of trying to anticipate what the new design patterns will be, we're just going to get the React Label component in sync with the ViewComponents Label component
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing we deprecate the current Label, StateLabel, and possibly CounterLabel components and introduce a new one where we support the design work @auareyou has been doing. Design issue link: https://github.com/github/primer/issues/192
The current Label component would require breaking changes in order to be compatible with color modes, so it would be impossible to get it to Beta.
TODO:
Screenshots
Coming soon
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Relevant links
https://github.com/github/primer/issues/568
https://github.com/github/primer/issues/192