Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major #1639

Merged
merged 34 commits into from
Nov 22, 2021
Merged

Next major #1639

merged 34 commits into from
Nov 22, 2021

Conversation

jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Nov 22, 2021

Merging the next_major branch into main

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

jfuchs and others added 4 commits November 22, 2021 10:54
* Dialog2 no longer accepts styled system props

* Update docs/content/Dialog2.mdx

Co-authored-by: Mike Perrotti <mperrotti@github.com>

Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jfuchs jfuchs requested review from jonrohan, colebemis and a team November 22, 2021 21:46
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2021

🦋 Changeset detected

Latest commit: 9d1d84d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 55.76 KB (-0.36% 🔽)
dist/browser.umd.js 56.17 KB (-0.37% 🔽)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo 🚀

@jfuchs jfuchs merged commit 8ce0eb9 into main Nov 22, 2021
@jfuchs jfuchs deleted the next_major branch November 22, 2021 21:58
@primer-css primer-css mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants