Dialog2 no longer accepts styled system props #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5589a98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
5ae6e28 to
68ecaa1
Compare
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
68ecaa1 to
dfe6159
Compare
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
dfe6159 to
e5cbb79
Compare
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
e5cbb79 to
40a1b68
Compare
size-limit report 📦
|
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
40a1b68 to
bdd6775
Compare
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
bdd6775 to
8b2a304
Compare
jfuchs
force-pushed
the
jfuchs/dialog2-props
branch
from
8b2a304 to
7d826f1
Compare
mperrotti
approved these changes
Nov 19, 2021
| } | ||
|
|
||
| export function shouldNotAcceptSystemProps() { | ||
| // @ts-expect-error system props should not be accepted |
There was a problem hiding this comment.
Wow, I didn't know @ts-expect-error was a thing. Cool!
There was a problem hiding this comment.
I love writing type tests now! Given how many regressions I've run into around types, it's nice to have some more confidence!
Co-authored-by: Mike Perrotti <mperrotti@github.com>
jfuchs
added a commit
that referenced
this pull request
Nov 22, 2021
* Dialog2 no longer accepts styled system props * Update docs/content/Dialog2.mdx Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com>
jfuchs
added a commit
that referenced
this pull request
Nov 22, 2021
* Set up a next_major branch * Breadcrumbs no longer accepts styled system props (#1469) * CircleBadge no longer accepts styled system props (#1555) * FilteredSearch no longer accepts styled system props (#1559) * FilterList no longer accepts styled system props (#1560) * FormGroup no longer accepts styled system props (#1562) * LabelGroup no longer accepts styled system props (#1565) * Pagination no longer accepts styled system props (#1569) * Popover no longer accepts styled system props (#1570) * SideNav no longer accepts styled system props (#1572) * TabNav no longer accepts styled system props (#1575) * Timeline no longer accepts styled system props (#1576) * Truncate no longer accepts styled system props (#1578) * StateLabel no longer accepts styled system props (#1573) * Buttons no longer accept styled system props (#1475) * CounterLabel no longer accepts styled system props (#1557) * Dropdown no longer accepts styled system props (#1558) * Flash no longer accepts styled system props (#1561) * Header no longer accepts styled system props (#1563) * Label no longer accepts styled system props (#1564) * Link no longer accepts styled system props (#1566) * Overlay no longer accepts styled system props (#1567) * Pagehead no longer accepts styled system props (#1568) * SelectMenu no longer accepts styled system props (#1571) * SubNav no longer accepts styled system props (#1574) * Tooltip no longer accepts styled system props (#1577) * UnderlineNav no longer accepts styled system props (#1579) * Fixes some TypeScript errors in the next_major branch (#1621) * Dialog no longer accepts styled system props (#1615) * StyledOcticon no longer accepts styled system props (#1616) * Dialog2 no longer accepts styled system props (#1614) * Dialog2 no longer accepts styled system props * Update docs/content/Dialog2.mdx Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com> * Version Packages (next) (#1612) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Revert "Version Packages (next) (#1612)" (#1637) This reverts commit 53f37a4. * Remove pre.json Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: GitHub Design Systems Bot <30705008+primer-css@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Dialog2 (AKA
src/Dialog/Dialog.tsx) to no longer accept system props.See github/primer#296
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.