Move flex-shrink: 0 to BaseVisualContainer.

[dmarcey]

This is to address a bug where in a single-select action menu, if an item wraps, it will become misaligned with other items in the list.

Closes #1595

Screenshots

Before:

After:

Story changes (not included in PR) that I made to repro this scenario:

@dmarcey ➜ /workspaces/react (main ✗) $ git diff src/stories/ActionList.stories.tsx 
diff --git a/src/stories/ActionList.stories.tsx b/src/stories/ActionList.stories.tsx
index 46e21e2c..0c03ccbe 100644
--- a/src/stories/ActionList.stories.tsx
+++ b/src/stories/ActionList.stories.tsx
@@ -106,13 +106,15 @@ const selectListItems = new Array(6).fill(undefined).map((_, i) => {
     id: i
   }
 })
+selectListItems.push({id: 6, text: 'Item with a really really long text value that should wrap'})
 
 export function SingleSelectListStory(): JSX.Element {
   return (
     <>
       <h1>Single Select List</h1>
-      <ErsatzOverlay>
+      <ErsatzOverlay maxWidth="300px">
         <ActionList
+          showItemDividers={true}
           items={selectListItems.map((item, index) => ({
             ...item,
             selected: index === 1

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

[changeset-bot]

🦋 Changeset detected

Latest commit: a7ce0e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	57.31 KB (-0.01% 🔽)
dist/browser.umd.js	57.72 KB (-0.01% 🔽)

[dmarcey]

Instead of this change, I think we could move the flex-shrink: 0 to an sx prop on the <BaseVisualContainer /> used in <Item /> for single-select action lists, but this seemed like a more correct fix.

Happy to switch to the more targeted approach if we feel like it is safer.

[siddharthkp]

LGTM!

[siddharthkp]

@dmarcey Sorry for letting this go stale! Do you mind updating this with main and i'll merge this?

[dmarcey]

@dmarcey Sorry for letting this go stale! Do you mind updating this with main and i'll merge this?

Thanks @siddharthkp! Rebase complete and CI is green!