Use Isomorphic effect #1583
Merged
Use Isomorphic effect #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a17e3d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
pksjce
force-pushed
the
pk/overlay-fix
branch
from
11f64f1
to
90183a3
Compare
siddharthkp
approved these changes
Nov 8, 2021
|
Good fix! Ship it when the tests pass :) |
Merged
pksjce
added a commit
that referenced
this pull request
Nov 15, 2021
* Use Isomorphic effect * Create brown-squids-unite.md * Fix eslint rules * Make it typescript * Add back the eslint disables * Fix up the tests and make the method more robust * Fix lint Co-authored-by: Pavithra Kodmad <pksjce@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
In #1453, we see that
useLayoutEffectcauses SSR warnings. This is the nature of the function. One proven way of mitigating this is to useuseLayoutEffectin the client mode anduseEffectwhen called in the SSR mode.Reference - https://medium.com/@alexandereardon/uselayouteffect-and-ssr-192986cdcf7a
Closes #1453
Screenshots
No changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.