Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Split <Item> labels #1320

Merged
merged 7 commits into from
Jun 25, 2021
Merged

fix: Split <Item> labels #1320

merged 7 commits into from
Jun 25, 2021

Commits on Jun 23, 2021

  1. Configuration menu
    Copy the full SHA
    09970b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0229d93 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f38b828 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Configuration menu
    Copy the full SHA
    254a4a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. fix: Restore semi-full-width 'Item' dividers, without giving up the s…

    …emantic nesting.
    
    By “semantic nesting”, I mean that the 'Item' label and description are now siblings, which is preferable to the previous implementation, where the description node was a child of the label node. As a general principle, we should align DOM hierarchies with information hierarchies. An analogy: If I were using a bulleted list to describe a dog, I would not indent its breed as a second-level bullet beneath the bullet for its name, because a dog’s breed is not dependent/derived data from its name. Similarly, description is not dependent/derived from label, and so should not be nested in DOM.
    smockle committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    408ff24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73eed06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5002b7b View commit details
    Browse the repository at this point in the history