Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TabNav component to TSX #1029

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Conversation

VanAnderson
Copy link
Contributor

@VanAnderson VanAnderson commented Feb 8, 2021

This PR migrates the TabNav component to TypeScript as part of the TypeScript refactor.

@vercel
Copy link

vercel bot commented Feb 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/j33o0lus6
✅ Preview: https://primer-components-git-vananderson-migrate-tab-nav-to-tsx.primer.now.sh

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2021

🦋 Changeset detected

Latest commit: adcb4b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:34 Inactive
@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:40 Inactive
src/TabNav.tsx Outdated
Comment on lines 14 to 17
const TabNavParent = styled.nav`
${COMMON}
${sx}
`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt like a weird thing to do - I was trying to parallel some patterns in src/UnderlineNav.tsx and I could not get the props for L19 unless I had an existing Parent element here.

This also seems to be producing some console errors in the tests (though they still pass):
image

Not sure if the tests needs to be adjusted or if trying to pull out a parent like this is just a bad idea?

@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:47 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review February 9, 2021 01:03
@VanAnderson VanAnderson mentioned this pull request Feb 9, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 9, 2021 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview February 9, 2021 17:03 Inactive
@colebemis colebemis merged commit d6f90b2 into main Feb 9, 2021
@colebemis colebemis deleted the VanAnderson/migrate-tab-nav-to-tsx branch February 9, 2021 18:09
@github-actions github-actions bot mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants