Skip to content

Make Block shadow prop accept "small" instead of true #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emplums merged 4 commits into from
Jul 6, 2018
Merged

Make Block shadow prop accept "small" instead of true #102

emplums merged 4 commits into from
Jul 6, 2018

Conversation

@shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jul 2, 2018

The shadow prop of Block (and Box) no longer accepts the boolean true. Instead, pass shadow="small" to add the box-shadow class name.

Fixes #76.

@shawnbot shawnbot requested review from a team and emplums and removed request for emplums July 2, 2018 19:47
emplums
emplums suggested changes Jul 2, 2018
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Block example in the docs to document this prop a little better? Otherwise this looks great! 🎉

@emplums
Copy link

emplums commented Jul 2, 2018 •
edited
Loading

  • The docs for this component might be a good candidate for the PropsForm Kit component! There's an example of that in usage with the FlexContainer component if you want to check it out!

@shawnbot
Copy link
Contributor Author

shawnbot commented Jul 3, 2018

Docs updated! ❤️

@emplums emplums mentioned this pull request Jul 3, 2018
Merged
6 tasks
@shawnbot
Copy link
Contributor Author

shawnbot commented Jul 3, 2018

@emplums do you mind giving this one more look? 🙇

@shawnbot
Copy link
Contributor Author

shawnbot commented Jul 3, 2018

Feel free to merge this while I'm out if it looks good! ✌️

@emplums emplums merged commit e4bf03c into release-0.0.7-beta Jul 6, 2018
@emplums emplums deleted the box-shadow-refactor branch July 6, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emplums emplums emplums approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawnbot @emplums