Closed
Description
This is a scheduled issue for tracking the release between Monday 26th and Friday 30th
Last week | Value |
---|---|
Issue | Release Tracking |
Conductor | siddharthkp |
Release Pull Request | Link |
Integration tests | Link |
Report for @primer/react integration test with github/github
https://docs.google.com/spreadsheets/d/17vCb-5_xXVJ6WrwWQYINdyjcnkpbUml4oFi5eTGjcTU/edit#gid=0
Timeline
Monday, June 26th
Tuesday, June 27th
Review lab tests for the previous release upgrade PR
Wednesday, June 28th
Primer nightly is broken due to some failing on licence upgrade - https://github.com/github/github/pull/278421 fixes it
Thursday, June 29th:
- Integration PR is manually created at github/github due to an ongoing issue with the npm workspaces (installing node modules under npm-workspaces/primer - https://github.com/github/github/pull/278552)
- Revert "Accessibility engineering review for Link component." #3459
- This PR removes the as prop from Link component however there are currently 15 usages at github/github that has as prop (error log at dotcom for reference)
- This PR introduces an optional to prop as a string type on the ActionList.LinkItem component. This does look a minor change however it is breaking existing usages. The current ActionList.LinkItem component and NavList (it uses ActionList.LinkItem in the background) pass the given props through and because to is a special prop name for react router, folks already have usages with this to prop. Limiting this prop to be string is breaking existing usages. (error log at dotcom for reference)
- Blocked on testing the pre-release at dotcom due to failings on the changeset https://github.com/primer/react/actions/runs/5408497752/jobs/9827626280?pr=3459 (slack ref)
Friday, June 30th
- Changeset issues are all fixed and unblocked on testing.
- Revert "Reintroduce aria-hidden=true asterisk changes" #3465
- This PR removes
aria-hidden=true
fromspan
s with required asterisk but there are failing tests at dotcom that relies on having aria-hidden="true" attribute (error log at dotcom)
- This PR removes
- Integration tests are all green 🎉 See the latest commit - Once we merge the Revert "Reintroduce aria-hidden=true asterisk changes" #3465 into main and review lab tests, I think we are safe to publish the release.
Checklist
- Checks have passed on the integration Pull Request downstream
- Release tracking Pull Request has been merged
- Stable release available on npm
- Downstream repos have been updated to latest
Notes
Metadata
Metadata
Assignees
Labels
No labels