Closed
Description
This is a scheduled issue for tracking the release between Monday 5th and Friday 9th
Last week | Value |
---|---|
Issue | #3341 |
Conductor | @joshblack |
Release Pull Request | Link |
Integration tests | Link |
Timeline
-
Monday, June 5th
- Deploys are still blocked at dotcom (https://github.com/github/engineering/discussions/3190)
-
Tuesday, June 6th
- Deploys are still blocked at dotcom (https://github.com/github/engineering/discussions/3190)
-
Wednesday, June 7th
Cannot read properties of undefined (reading 'extraneous')
npm issue blocked primer nightly. (slack reference)
-
Thursday, June 8th
- npm issue is resolved by the dotcom engineers. Ran primer nightly and investigated the failing checks.
ActionMenu
undersrc
is deleted and moved into its own folder. This change was causing an issue on memex modules as it has been imported with an explicit path. error log & commit for fix- There was a type issue on a styled
Truncate
due to not explicitly typed error log & commit for fix
- npm issue is resolved by the dotcom engineers. Ran primer nightly and investigated the failing checks.
-
Friday, June 9th
- In the Primer Engineering sync, team decided to lock the
main
branch and revert the PRs that are introducing breaking changes to dotcom.
- In the Primer Engineering sync, team decided to lock the
-
Tuesday, June 13 and the following days
- @broccolinisoup and @colebemis paired to revert the PRs that are introducing breaking changes to dotcom Revert PRs that are breaking dotcom to get the current release out #3408 and a new issue is created for integration tests: https://github.com/github/github/pull/276739
-
Friday, June 16
- https://github.com/github/github/pull/276739 got all the checks green and v35.26.0 is published
Checklist
- Checks have passed on the integration Pull Request downstream
- Release tracking Pull Request has been merged
- Stable release available on npm
- Downstream repos have been updated to latest - PR is ready but not merged as we have not completed regression tests on review lab yet. https://github.com/github/github/pull/276739
Notes
- Re-add the PRs that are reverted from
main
due to introducing breaking changes to github.com on the v35.26.0 release #3429 is created to re-introduce the PRs that are reverted.