diff --git a/.changeset/nice-apples-collect.md b/.changeset/nice-apples-collect.md new file mode 100644 index 00000000000..3f5f5d56457 --- /dev/null +++ b/.changeset/nice-apples-collect.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Remove z-index assignment that used to be necessary for the dropdown children of FilteredSearch diff --git a/docs/content/FilteredSearch.md b/docs/content/FilteredSearch.md index d94eef2bd86..6144da2e285 100644 --- a/docs/content/FilteredSearch.md +++ b/docs/content/FilteredSearch.md @@ -15,14 +15,14 @@ The FilteredSearch component helps style a Dropdown and a TextInput side-by-side Filter - + Item 1 Item 2 Item 3 - + ``` diff --git a/package-lock.json b/package-lock.json index f3e4535a9a3..ecd5bc298f5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@primer/react", - "version": "35.6.0", + "version": "35.7.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@primer/react", - "version": "35.6.0", + "version": "35.7.0", "license": "MIT", "dependencies": { "@github/combobox-nav": "^2.1.5", @@ -13236,14 +13236,20 @@ "dev": true }, "node_modules/caniuse-lite": { - "version": "1.0.30001237", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001237.tgz", - "integrity": "sha512-pDHgRndit6p1NR2GhzMbQ6CkRrp4VKuSsqbcLeOQppYPKOYkKT/6ZvZDvKJUqcmtyWIAHuZq3SVS2vc1egCZzw==", + "version": "1.0.30001381", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001381.tgz", + "integrity": "sha512-fEnkDOKpvp6qc+olg7+NzE1SqyfiyKf4uci7fAU38M3zxs0YOyKOxW/nMZ2l9sJbt7KZHcDIxUnbI0Iime7V4w==", "dev": true, - "funding": { - "type": "opencollective", - "url": "https://opencollective.com/browserslist" - } + "funding": [ + { + "type": "opencollective", + "url": "https://opencollective.com/browserslist" + }, + { + "type": "tidelift", + "url": "https://tidelift.com/funding/github/npm/caniuse-lite" + } + ] }, "node_modules/capture-exit": { "version": "2.0.0", @@ -14603,16 +14609,6 @@ "url": "https://opencollective.com/browserslist" } }, - "node_modules/core-js-compat/node_modules/caniuse-lite": { - "version": "1.0.30001271", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001271.tgz", - "integrity": "sha512-BBruZFWmt3HFdVPS8kceTBIguKxu4f99n5JNp06OlPD/luoAMIaIK5ieV5YjnBLH3Nysai9sxj9rpJj4ZisXOA==", - "dev": true, - "funding": { - "type": "opencollective", - "url": "https://opencollective.com/browserslist" - } - }, "node_modules/core-js-compat/node_modules/electron-to-chromium": { "version": "1.3.879", "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.3.879.tgz", @@ -47318,9 +47314,9 @@ "dev": true }, "caniuse-lite": { - "version": "1.0.30001237", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001237.tgz", - "integrity": "sha512-pDHgRndit6p1NR2GhzMbQ6CkRrp4VKuSsqbcLeOQppYPKOYkKT/6ZvZDvKJUqcmtyWIAHuZq3SVS2vc1egCZzw==", + "version": "1.0.30001381", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001381.tgz", + "integrity": "sha512-fEnkDOKpvp6qc+olg7+NzE1SqyfiyKf4uci7fAU38M3zxs0YOyKOxW/nMZ2l9sJbt7KZHcDIxUnbI0Iime7V4w==", "dev": true }, "capture-exit": { @@ -48336,12 +48332,6 @@ "picocolors": "^1.0.0" } }, - "caniuse-lite": { - "version": "1.0.30001271", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001271.tgz", - "integrity": "sha512-BBruZFWmt3HFdVPS8kceTBIguKxu4f99n5JNp06OlPD/luoAMIaIK5ieV5YjnBLH3Nysai9sxj9rpJj4ZisXOA==", - "dev": true - }, "electron-to-chromium": { "version": "1.3.879", "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.3.879.tgz", diff --git a/src/FilteredSearch.tsx b/src/FilteredSearch.tsx index 888a9cc7ade..73d3c280ffd 100644 --- a/src/FilteredSearch.tsx +++ b/src/FilteredSearch.tsx @@ -18,7 +18,6 @@ const FilteredSearch = styled.div` border-radius: 0; border-top-right-radius: ${get('radii.2')}; border-bottom-right-radius: ${get('radii.2')}; - z-index: 1; // Allows the focus outline to show on top of the dropdown. } ${sx} diff --git a/src/__tests__/__snapshots__/FilteredSearch.test.tsx.snap b/src/__tests__/__snapshots__/FilteredSearch.test.tsx.snap index b093bbf8a7f..6550de5f738 100644 --- a/src/__tests__/__snapshots__/FilteredSearch.test.tsx.snap +++ b/src/__tests__/__snapshots__/FilteredSearch.test.tsx.snap @@ -24,7 +24,6 @@ exports[`FilteredSearch renders consistently 1`] = ` border-radius: 0; border-top-right-radius: 6px; border-bottom-right-radius: 6px; - z-index: 1; }