Skip to content

Commit d1dc7fa

Browse files
authored
Remove eslint disable from ActionMenu story; edit story to be keyboard accessible (#5341)
1 parent 3fcfba8 commit d1dc7fa

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,22 @@ export const ShortcutMenu = () => {
235235

236236
export const ContextMenu = () => {
237237
const ListItemWithContextMenu = ({children}: {children: string}) => {
238-
const handleContextMenu: React.MouseEventHandler<HTMLLIElement> = event => {
238+
const handleContextMenu: React.MouseEventHandler<HTMLElement> = event => {
239239
event.preventDefault()
240240
setOpen(true)
241241
}
242242

243243
const [open, setOpen] = React.useState(false)
244-
const triggerRef = React.useRef<HTMLLIElement>(null)
244+
const triggerRef = React.useRef<HTMLButtonElement>(null)
245245

246246
return (
247-
// We need to add an aria-label for improving support for more assistive technologies. For example: VoiceOver might not detect the `name` without `aria-label`
248-
// Since this has a custom context menu, it's ok to add a tabIndex
249-
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
250-
<li ref={triggerRef} onContextMenu={handleContextMenu} tabIndex={0} aria-label={children}>
251-
{children}
247+
<li onContextMenu={handleContextMenu}>
252248
<ActionMenu open={open} onOpenChange={setOpen} anchorRef={triggerRef}>
253-
<ActionMenu.Button sx={{visibility: 'hidden', height: 0}}>Anchor</ActionMenu.Button>
249+
<ActionMenu.Anchor>
250+
<Button ref={triggerRef} variant="invisible" onClick={handleContextMenu}>
251+
{children}
252+
</Button>
253+
</ActionMenu.Anchor>
254254
<ActionMenu.Overlay>
255255
<ActionList>
256256
<ActionList.Item>

0 commit comments

Comments
 (0)