CounterLabel: Do not parse children to string for visually hidden con…

…tent (#2850) * Parse children as is for visually hidden content * update snapshots
primer · Feb 2, 2023 · ca7398d · ca7398d
1 parent 03b470b
commit ca7398d
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 19 deletions.
diff --git a/.changeset/rare-panthers-smash.md b/.changeset/rare-panthers-smash.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+CounterLabel: Do not parse children to string for visually hidden content
diff --git a/src/CounterLabel.tsx b/src/CounterLabel.tsx
@@ -38,7 +38,7 @@ const CounterLabel: React.FC<React.PropsWithChildren<CounterLabelProps>> = ({
       >
         {children}
       </Box>
-      <VisuallyHidden>&nbsp;{`(${children})`}</VisuallyHidden>
+      <VisuallyHidden>&nbsp;({children})</VisuallyHidden>
     </>
   )
 }

diff --git a/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap b/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap
@@ -318,8 +318,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (120)
+                 (
+                120
+                )
               </span>
             </span>
           </div>
@@ -386,8 +387,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (13)
+                 (
+                13
+                )
               </span>
             </span>
           </div>
@@ -454,8 +456,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (5)
+                 (
+                5
+                )
               </span>
             </span>
           </div>
@@ -494,8 +497,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (4)
+                 (
+                4
+                )
               </span>
             </span>
           </div>
@@ -562,8 +566,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (9)
+                 (
+                9
+                )
               </span>
             </span>
           </div>
@@ -653,8 +658,9 @@ exports[`UnderlineNav renders consistently 1`] = `
               <span
                 className="c0"
               >
-                 
-                (10)
+                 (
+                10
+                )
               </span>
             </span>
           </div>

diff --git a/src/__tests__/__snapshots__/CounterLabel.test.tsx.snap b/src/__tests__/__snapshots__/CounterLabel.test.tsx.snap
@@ -37,8 +37,8 @@ exports[`CounterLabel renders consistently 1`] = `
 <span
     className="c0"
   >
-     
-    (undefined)
+     (
+    )
   </span>,
 ]
 `;
@@ -82,8 +82,9 @@ exports[`CounterLabel renders with secondary scheme when no "scheme" prop is pro
   <span
     class="c1"
   >
-     
-    (1234)
+     (
+    1234
+    )
   </span>
 </div>
 `;
@@ -127,8 +128,9 @@ exports[`CounterLabel respects the primary "scheme" prop 1`] = `
   <span
     class="c1"
   >
-     
-    (1234)
+     (
+    1234
+    )
   </span>
 </div>
 `;