Skip to content

Commit c9009de

Browse files
fix(Pagination): Use anchor instead of button for disabled prev/next controls (#4951)
* fix(Pagination): a11y improvements * Create friendly-boats-serve.md * fix(Pagination): only add role link to disabled anchors
1 parent b74c47f commit c9009de

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

.changeset/friendly-boats-serve.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": minor
3+
---
4+
5+
fix(Pagination): Use anchor instead of button for disabled prev/next controls

packages/react/src/Pagination/Pagination.tsx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,11 @@ const Page = styled.a`
7676
7777
&[aria-disabled],
7878
&[aria-disabled]:hover {
79-
color: ${get('colors.primer.fg.disabled')}; // check
80-
cursor: default;
81-
background-color: transparent;
82-
border-color: transparent;
83-
font-size: inherit;
84-
font-family: inherit;
85-
padding-top: inherit;
86-
padding-bottom: inherit;
79+
margin: 0 2px;
80+
81+
&:first-child {
82+
margin-right: 6px;
83+
}
8784
}
8885
8986
&[aria-disabled],

packages/react/src/Pagination/model.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export function buildComponentData(
148148
key = 'page-prev'
149149
content = 'Previous'
150150
if (page.disabled) {
151-
Object.assign(props, {as: 'button', 'aria-disabled': 'true'})
151+
Object.assign(props, {'aria-disabled': 'true', role: 'link'})
152152
} else {
153153
Object.assign(props, {
154154
rel: 'prev',
@@ -163,7 +163,7 @@ export function buildComponentData(
163163
key = 'page-next'
164164
content = 'Next'
165165
if (page.disabled) {
166-
Object.assign(props, {as: 'button', 'aria-disabled': 'true'})
166+
Object.assign(props, {'aria-disabled': 'true', role: 'link'})
167167
} else {
168168
Object.assign(props, {
169169
rel: 'next',

0 commit comments

Comments
 (0)