don't recreate hostElements each time (#4033)

* don't recreate hostElements each time * changeset
primer · Dec 8, 2023 · bca709d · bca709d
1 parent 83c125f
commit bca709d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/sweet-onions-heal.md b/.changeset/sweet-onions-heal.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Fixed confirm() leaving <div>s in the DOM.
diff --git a/src/ConfirmationDialog/ConfirmationDialog.tsx b/src/ConfirmationDialog/ConfirmationDialog.tsx
@@ -150,7 +150,7 @@ export type ConfirmOptions = Omit<ConfirmationDialogProps, 'onClose'> & {content
 async function confirm(themeProps: ThemeProviderProps, options: ConfirmOptions): Promise<boolean> {
   const {content, ...confirmationDialogProps} = options
   return new Promise(resolve => {
-    hostElement = document.createElement('div')
+    hostElement ||= document.createElement('div')
     if (!hostElement.isConnected) document.body.append(hostElement)
     const root = createRoot(hostElement)
     const onClose: ConfirmationDialogProps['onClose'] = gesture => {