Fix leaking drag handler event

pksjce · pksjce · commit ac62fd59318d · 2023-11-07T15:43:36.000+11:00
diff --git a/src/PageLayout/PageLayout.tsx b/src/PageLayout/PageLayout.tsx
@@ -314,6 +314,8 @@ const VerticalDivider: React.FC<React.PropsWithChildren<DividerProps & Draggable
     return () => {
       window.removeEventListener('mousemove', handleDrag)
       window.removeEventListener('mouseup', handleDragEnd)
+      window.removeEventListener('keydown', handleKeyDrag)
+      window.removeEventListener('keyup', handleKeyDragEnd)
       document.body.removeAttribute('data-page-layout-dragging')
     }
   }, [isDragging, isKeyboardDrag, currentWidth, minWidth, maxWidth])

Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,8 @@ const VerticalDivider: React.FC<React.PropsWithChildren<DividerProps & Draggable`
`314`	`314`	`return () => {`
`315`	`315`	`window.removeEventListener('mousemove', handleDrag)`
`316`	`316`	`window.removeEventListener('mouseup', handleDragEnd)`
	`317`	`+ window.removeEventListener('keydown', handleKeyDrag)`
	`318`	`+ window.removeEventListener('keyup', handleKeyDragEnd)`
`317`	`319`	`document.body.removeAttribute('data-page-layout-dragging')`
`318`	`320`	`}`
`319`	`321`	`}, [isDragging, isKeyboardDrag, currentWidth, minWidth, maxWidth])`