Skip to content

Commit 931d73b

Browse files
committed
marks 'extralarge' as deprecated
1 parent cc4c090 commit 931d73b

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/Token/TokenBase.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ import {get} from '../constants'
55
import sx, {SxProp} from '../sx'
66

77
// TODO: remove invalid "extralarge" size name in next breaking change
8-
// ADR: https://github.com/github/primer/blob/main/adrs/2022-02-09-size-naming-guidelines.md
9-
export type TokenSizeKeys = 'small' | 'medium' | 'large' | 'extralarge' | 'xlarge'
8+
/** @deprecated 'extralarge' to be removed to align with size naming ADR https://github.com/github/primer/blob/main/adrs/2022-02-09-size-naming-guidelines.md **/
9+
type ExtraLarge = 'extralarge'
10+
export type TokenSizeKeys = 'small' | 'medium' | 'large' | 'xlarge' | ExtraLarge
1011

1112
const xlargeSize = '32px'
1213

src/__tests__/__snapshots__/TextInputWithTokens.test.tsx.snap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4123,7 +4123,8 @@ exports[`TextInputWithTokens renders tokens at the specified sizes 4`] = `
41234123
margin-right: 8px;
41244124
}
41254125
4126-
.c0 .TextInput-icon {
4126+
.c0 .TextInput-icon,
4127+
.c0 .TextInput-action {
41274128
-webkit-align-self: center;
41284129
-ms-flex-item-align: center;
41294130
align-self: center;

0 commit comments

Comments
 (0)