Skip to content

Commit

Permalink
Next major (#1639)
Browse files Browse the repository at this point in the history
* Set up a next_major branch

* Breadcrumbs no longer accepts styled system props (#1469)

* CircleBadge no longer accepts styled system props (#1555)

* FilteredSearch no longer accepts styled system props (#1559)

* FilterList no longer accepts styled system props (#1560)

* FormGroup no longer accepts styled system props (#1562)

* LabelGroup no longer accepts styled system props (#1565)

* Pagination no longer accepts styled system props (#1569)

* Popover no longer accepts styled system props (#1570)

* SideNav no longer accepts styled system props (#1572)

* TabNav no longer accepts styled system props (#1575)

* Timeline no longer accepts styled system props (#1576)

* Truncate no longer accepts styled system props (#1578)

* StateLabel no longer accepts styled system props (#1573)

* Buttons no longer accept styled system props (#1475)

* CounterLabel no longer accepts styled system props (#1557)

* Dropdown no longer accepts styled system props (#1558)

* Flash no longer accepts styled system props (#1561)

* Header no longer accepts styled system props (#1563)

* Label no longer accepts styled system props (#1564)

* Link no longer accepts styled system props (#1566)

* Overlay no longer accepts styled system props (#1567)

* Pagehead no longer accepts styled system props (#1568)

* SelectMenu no longer accepts styled system props (#1571)

* SubNav no longer accepts styled system props (#1574)

* Tooltip no longer accepts styled system props (#1577)

* UnderlineNav no longer accepts styled system props (#1579)

* Fixes some TypeScript errors in the next_major branch (#1621)

* Dialog no longer accepts styled system props (#1615)

* StyledOcticon no longer accepts styled system props (#1616)

* Dialog2 no longer accepts styled system props (#1614)

* Dialog2 no longer accepts styled system props

* Update docs/content/Dialog2.mdx

Co-authored-by: Mike Perrotti <mperrotti@github.com>

Co-authored-by: Mike Perrotti <mperrotti@github.com>

* Version Packages (next) (#1612)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Revert "Version Packages (next) (#1612)" (#1637)

This reverts commit 53f37a4.

* Remove pre.json

Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: GitHub Design Systems Bot <30705008+primer-css@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
4 people authored Nov 22, 2021
1 parent 2824e03 commit 8ce0eb9
Show file tree
Hide file tree
Showing 146 changed files with 1,112 additions and 879 deletions.
5 changes: 5 additions & 0 deletions .changeset/beige-dots-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Truncate no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/brave-trains-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Timeline no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/bright-baboons-peel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Dropdown no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/chilly-socks-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Pagehead no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/eleven-cycles-search.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

LabelGroup no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/fast-fireants-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Link no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/gentle-birds-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Popover no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/gentle-tips-hear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

StateLabel no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/gold-countries-kneel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

CircleBadge no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/large-chefs-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

SelectMenu no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/little-bats-repeat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Header no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/lucky-hounds-lie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

UnderlineNav no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/lucky-zoos-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Overlay no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/mean-bananas-explain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

StyledOcticon no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/moody-buttons-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Dialog no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/neat-masks-grab.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

TabNav no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/new-tigers-yawn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

SubNav no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/old-taxis-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Dialog2 no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/purple-buttons-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Buttons no longer accept styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/rotten-apricots-float.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Label no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/shaggy-pens-run.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Flash no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/silver-worms-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Tooltip no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/spicy-olives-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Pagination no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/spicy-seas-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

Breadcrumbs no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/swift-days-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

FilteredSearch no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/tender-beds-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

SideNav no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/twenty-coins-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

FilterList no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/unlucky-snails-pull.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

CounterLabel no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
5 changes: 5 additions & 0 deletions .changeset/wild-olives-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/components': major
---

FormGroup no longer accepts styled-system props. Please use the `sx` prop to extend Primer component styling instead. See also https://primer.style/react/overriding-styles for information about `sx` and https://primer.style/react/system-props for context on the removal.
27 changes: 11 additions & 16 deletions docs/content/Breadcrumbs.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,26 +27,21 @@ This ensures that the NavLink gets `activeClassName='selected'`
</Breadcrumbs>
```

## System props

<Note variant="warning">

System props are deprecated in all components except [Box](/Box). Please use the [`sx` prop](/overriding-styles) instead.

</Note>

Breadcrumbs and Breadcrumbs.Item components get `COMMON` system props. Read our [System Props](/system-props) doc page for a full list of available props.

## Component props

### Breadcrumbs

The `Breadcrumbs` component does not receive any additional props besides `COMMON` system props.
| Prop name | Type | Default | Description |
| :-------- | :---------------- | :-----: | :----------------------------------- |
| children | ReactNode | | The `Breadcrumbs.Item`s |
| className | string | | |
| sx | SystemStyleObject | `{}` | Style to be applied to the component |

### Breadcrumbs.Item

| Prop name | Type | Default | Description |
| :-------- | :------ | :-----: | :----------------------------------------------- |
| as | String | `a` | Sets the HTML tag for the component |
| href | String | | URL to be used for the Link |
| selected | Boolean | false | Used to style the link as selected or unselected |
| Prop name | Type | Default | Description |
| :-------- | :---------------- | :-----: | :----------------------------------------------- |
| as | string | `a` | Sets the HTML tag for the component |
| href | string | | URL to be used for the Link |
| selected | boolean | `false` | Used to style the link as selected or unselected |
| sx | SystemStyleObject | `{}` | Style to be applied to the component |
24 changes: 7 additions & 17 deletions docs/content/Buttons.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ To create a button group, wrap `Button` elements in the `ButtonGroup` element. `
<ButtonOutline>Button Outline</ButtonOutline>
<ButtonPrimary>Button Primary</ButtonPrimary>
<ButtonInvisible>Button Invisible</ButtonInvisible>
<ButtonClose onClick={() => window.alert('button clicked')}/>
<ButtonClose onClick={() => window.alert('button clicked')} />

<ButtonGroup display='block' my={2}>
<ButtonGroup display="block" my={2}>
<Button>Button</Button>
<Button>Button</Button>
<Button>Button</Button>
Expand All @@ -29,27 +29,17 @@ To create a button group, wrap `Button` elements in the `ButtonGroup` element. `
</>
```

## System props

<Note variant="warning">

System props are deprecated in all components except [Box](/Box). Please use the [`sx` prop](/overriding-styles) instead.

</Note>

`Button` and `ButtonGroup` components get `COMMON` and `LAYOUT` system props. Read our [System Props](/system-props) doc page for a full list of available props.

## Component props

Native `<button>` HTML attributes are forwarded to the underlying React `button` component and are not listed below.

### Button

| Prop name | Type | Default | Description |
| :-------- | :--------------- | :------: | :-------------------------------------------------------------------------------------------------------------------------- |
| as | String | `button` | sets the HTML tag for the component |
| fontSize | Number or String | | explicitly sets the font size for the Button text; overrides any value for the `variant` prop |
| variant | String | 'medium' | a value of `small`, `medium`, or `large` results in smaller or larger Button text size; no effect if `fontSize` prop is set |
| Prop name | Type | Default | Description |
| :-------- | :---------------- | :------: | :-------------------------------------------------------------------------------------------------------------------------- |
| as | String | `button` | sets the HTML tag for the component |
| sx | SystemStyleObject | {} | Additional styles |
| variant | String | 'medium' | a value of `small`, `medium`, or `large` results in smaller or larger Button text size; no effect if `fontSize` prop is set |

### ButtonGroup

Expand Down
10 changes: 0 additions & 10 deletions docs/content/CircleBadge.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,6 @@ Use CircleBadge to visually connect logos of third party services like in market
</CircleBadge>
```

## System props

<Note variant="warning">

System props are deprecated in all components except [Box](/Box). Please use the [`sx` prop](/overriding-styles) instead.

</Note>

CircleBadge and CircleBadge.Icon components get `COMMON` system props. Read our [System Props](/system-props) doc page for a full list of available props.

## Component props

### CircleBadge
Expand Down
10 changes: 0 additions & 10 deletions docs/content/CounterLabel.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ Use the CounterLabel component to add a count to navigational elements and butto
</>
```

## System props

<Note variant="warning">

System props are deprecated in all components except [Box](/Box). Please use the [`sx` prop](/overriding-styles) instead.

</Note>

CounterLabel components get `COMMON` system props. Read our [System Props](/system-props) doc page for a full list of available props.

## Component props

| Name | Type | Default | Description |
Expand Down
33 changes: 15 additions & 18 deletions docs/content/Dialog.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,25 +84,22 @@ You can also pass any non-text content into the header:
</State>
```
## System props
<Note variant="warning">
System props are deprecated in all components except [Box](/Box). Please use the [`sx` prop](/overriding-styles) instead.
</Note>
## Component props
`Dialog` components get the `COMMON` and `LAYOUT` categories of system props. `Dialog.Header` components get `COMMON`, `LAYOUT`, and `FLEX` system props. Read our [System Props](/system-props) doc page for a full list of available props.
### Dialog
## Component props
| Prop name | Type | Default | Description |
| :-------------- | :---------------- | :------ | :-------------------------------------------------------------------------------------------------------------------------------------------------------- |
| isOpen | Boolean | | Set whether or not the dialog is shown |
| onDismiss | Function | | A user-provided function that should close the dialog |
| returnFocusRef | React ref | | The element to restore focus back to after the `Dialog` is closed |
| initialFocusRef | React ref | | Element inside of the `Dialog` you'd like to be focused when the Dialog is opened. If nothing is passed to `initialFocusRef` the close button is focused. |
| aria-labelledby | string | | Pass an id to use for the aria-label. Use either a `aria-label` or an `aria-labelledby` but not both. |
| aria-label | string | | Pass a label to be used to describe the Dialog. Use either a `aria-label` or an `aria-labelledby` but not both. |
| sx | SystemStyleObject | {} | Style to be applied to the component |

| Prop name | Type | Description |
| :-------------- | :-------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------- |
| isOpen | Boolean | Set whether or not the dialog is shown |
| onDismiss | Function | A user-provided function that should close the dialog |
| returnFocusRef | React ref | The element to restore focus back to after the `Dialog` is closed |
| initialFocusRef | React ref | Element inside of the `Dialog` you'd like to be focused when the Dialog is opened. If nothing is passed to `initialFocusRef` the close button is focused. |
| aria-labelledby | string | Pass an id to use for the aria-label. Use either a `aria-label` or an `aria-labelledby` but not both. |
| aria-label | string | Pass a label to be used to describe the Dialog. Use either a `aria-label` or an `aria-labelledby` but not both. |
### Dialog.Header

`Dialog.Header` does not take any non-system props.
| Prop name | Type | Default | Description |
| :-------- | :---------------- | :------ | :----------------------------------- |
| sx | SystemStyleObject | {} | Style to be applied to the component |
Loading

0 comments on commit 8ce0eb9

Please sign in to comment.