Skip to content

Commit 6c69bff

Browse files
authored
Refactor Link, Blankslate, Heading to use :where css (#4858)
* Refactor Link, Blankslate, Heading to use :where css * Create early-lions-vanish.md
1 parent 5ee8704 commit 6c69bff

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

.changeset/early-lions-vanish.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
Refactor Link, Blankslate, Heading to use :where css

packages/react/src/Blankslate/Blankslate.module.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@
1111
/* stylelint-disable-next-line primer/spacing */
1212
padding: var(--blankslate-outer-padding-block) var(--blankslate-outer-padding-inline);
1313

14-
&[data-spacious='true'] {
14+
&:where([data-spacious='true']) {
1515
--blankslate-outer-padding-block: var(--base-size-80);
1616
--blankslate-outer-padding-inline: var(--base-size-40);
1717
}
1818

19-
&[data-border='true'] {
19+
&:where([data-border='true']) {
2020
border: var(--borderWidth-thin) solid var(--borderColor-default);
2121
border-radius: var(--borderRadius-medium);
2222
}
2323

24-
&[data-narrow='true'] {
24+
&:where([data-narrow='true']) {
2525
max-width: 485px;
2626
margin: 0 auto;
2727
}
@@ -63,7 +63,7 @@
6363
--blankslate-outer-padding-block: var(--base-size-20);
6464
--blankslate-outer-padding-inline: var(--base-size-20);
6565

66-
&[data-spacious='true'] {
66+
&:where([data-spacious='true']) {
6767
--blankslate-outer-padding-block: var(--base-size-44);
6868
--blankslate-outer-padding-inline: var(--base-size-28);
6969
}

packages/react/src/Heading/Heading.module.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
font-size: var(--text-title-size-large);
44
font-weight: var(--base-text-weight-semibold);
55

6-
&[data-variant='large'] {
6+
&:where([data-variant='large']) {
77
font: var(--text-title-shorthand-large);
88
}
99

10-
&[data-variant='medium'] {
10+
&:where([data-variant='medium']) {
1111
font: var(--text-title-shorthand-medium);
1212
}
1313

14-
&[data-variant='small'] {
14+
&:where([data-variant='small']) {
1515
font: var(--text-title-shorthand-small);
1616
}
1717
}

packages/react/src/Link/Link.module.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@
2020
}
2121

2222
/* Deprecated: but need to support backwards compatibility */
23-
&[data-underline='true'],
23+
&:where([data-underline='true']),
2424
/*
2525
Inline links (inside a text block), however, should have underline based on accessibility setting set in data-attribute
2626
Note: setting underline={false} does not override this
2727
*/
28-
[data-a11y-link-underlines='true'] &[data-inline='true'] {
28+
[data-a11y-link-underlines='true'] &:where([data-inline='true']) {
2929
text-decoration: underline;
3030
}
3131

32-
&[data-muted='true'] {
32+
&:where([data-muted='true']) {
3333
color: var(--fgColor-muted);
3434

3535
&:hover {

0 commit comments

Comments
 (0)