Commit 5f996c6
SelectPanel: Update SelectPanel to use modern ActionList (#4794)
* super wip
* just use the actionlist component and revert the type updates
* Update packages/react/src/FilteredActionList/FilteredActionList.tsx
* Some more progress
* revert the type changes and cast it :/
* clean
* wip
* wip wip
* add stories
* fix linting
* add tests for groups
* Map groups
* Update story names for e2e tests
* oops remove unintended file
* update story name
* same - update story name
* disable animations
* test(vrt): update snapshots
* Update tests since new action list has different semantics for group headings
* logging
* pass the rest
* extract children and use before text
* remove logging
* test(vrt): update snapshots
* add active styles to ActionList
* rename component name to be clearer
* remove variant full from examples
* tiny clean up
* fix showItemDividers
* another tiny cleanup
* pull MappedActionListItem to make it stable
* test(vrt): update snapshots
* show active styles only when used with keyboard
* backward compat: expose id as data-id
* update snapshots
* add story for long strings
* fishing for errors
* backward compatibility for renderItem
* remove todo now
* add a feature flag
* clean up dual filter list setup
* run jests test with both states of feature flags
* refactor snapshot tests with scenarios
* remove feature flag for main
* test(vrt): update snapshots
* add feature flag to e2e matrix
* test(vrt): update snapshots
* backward compat: allow groupMetadata to be empty array
* sigh newline
* Create sour-cooks-dress.md
* copy SelectPanel snapshots from main
* remove unrelated changes in this PR
* test(vrt): update snapshots
* set active styles for both active-descendant types
* test(vrt): update snapshots
---------
Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>1 parent c282642 commit 5f996c6
File tree
130 files changed
+1016
-445
lines changed- .changeset
- .playwright/snapshots/components/SelectPanel.test.ts-snapshots
- e2e/components
- packages/react/src
- ActionList
- FeatureFlags
- FilteredActionList
- SelectPanel
- __tests__/__snapshots__
- deprecated/ActionList
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
130 files changed
+1016
-445
lines changed
0 commit comments