Skip to content

Commit

Permalink
ProgressBar: Remove aria-busy from ProgressBar (#4841)
Browse files Browse the repository at this point in the history
* Update snapshots

* Add changeset
  • Loading branch information
TylerJDev authored and jonrohan committed Aug 15, 2024
1 parent 68ad08b commit 5a51d41
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/sixty-olives-glow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Remove `aria-busy` from `ProgressBar` component
1 change: 0 additions & 1 deletion packages/react/src/ProgressBar/ProgressBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const ProgressBar = forwardRef<HTMLSpanElement, ProgressBarProps>(
'aria-valuenow': progressAsNumber ? Math.round(progressAsNumber) : undefined,
'aria-valuemin': 0,
'aria-valuemax': 100,
'aria-busy': progressAsNumber ? progressAsNumber !== 100 : false,
}

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ exports[`ProgressBar respects the "progress" prop 1`] = `
}
<span
aria-busy={true}
aria-label="Upload test.png"
aria-valuemax={100}
aria-valuemin={0}
Expand Down

0 comments on commit 5a51d41

Please sign in to comment.