fix(SelectPanel): do not depend on id for selection comparison

francinelucca · francinelucca · commit 5a28459c6a1c · 2025-04-30T14:24:57.000-04:00
diff --git a/packages/react/src/SelectPanel/SelectPanel.tsx b/packages/react/src/SelectPanel/SelectPanel.tsx
@@ -391,11 +391,11 @@ function Panel({
       // For single-select modal, there is an intermediate state when the user has selected
       // an item but has not yet saved the selection. We need to check for this state.
       if (isSingleSelectModal) {
-        return intermediateSelected?.id === item.id
+        return intermediateSelected === item
       }
 
       // For single-select anchored, we just need to check if the item is the selected item
-      return selected?.id === item.id
+      return selected === item
     },
     [selected, intermediateSelected, isSingleSelectModal],
   )

Original file line number	Diff line number	Diff line change
`@@ -391,11 +391,11 @@ function Panel({`
`391`	`391`	`// For single-select modal, there is an intermediate state when the user has selected`
`392`	`392`	`// an item but has not yet saved the selection. We need to check for this state.`
`393`	`393`	`if (isSingleSelectModal) {`
`394`		`- return intermediateSelected?.id === item.id`
	`394`	`+ return intermediateSelected === item`
`395`	`395`	`}`
`396`	`396`
`397`	`397`	`// For single-select anchored, we just need to check if the item is the selected item`
`398`		`- return selected?.id === item.id`
	`398`	`+ return selected === item`
`399`	`399`	`},`
`400`	`400`	`[selected, intermediateSelected, isSingleSelectModal],`
`401`	`401`	`)`