Skip to content

Commit

Permalink
NavList SSR: use useIsomorphicLayoutEffect instead of useLayoutEffect (
Browse files Browse the repository at this point in the history
…#3127)

* use useIsomorphicLayoutEffect

* Create .changeset/fast-panthers-refuse.md

---------

Co-authored-by: Josh Black <joshblack@github.com>
  • Loading branch information
siddharthkp and joshblack authored Apr 6, 2023
1 parent fc2b28a commit 5224fcb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/fast-panthers-refuse.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Suppress SSR warning for useLayoutEffect in NavList, use useIsomorphicLayoutEffect instead of useLayoutEffect
3 changes: 2 additions & 1 deletion src/NavList/NavList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import StyledOcticon from '../StyledOcticon'
import sx, {merge, SxProp} from '../sx'
import {defaultSxProp} from '../utils/defaultSxProp'
import {useId} from '../hooks/useId'
import useIsomorphicLayoutEffect from '../utils/useIsomorphicLayoutEffect'

// ----------------------------------------------------------------------------
// NavList
Expand Down Expand Up @@ -110,7 +111,7 @@ function ItemWithSubNav({children, subNav, sx: sxProp = defaultSxProp}: ItemWith
const subNavRef = React.useRef<HTMLDivElement>(null)
const [containsCurrentItem, setContainsCurrentItem] = React.useState(false)

React.useLayoutEffect(() => {
useIsomorphicLayoutEffect(() => {
if (subNavRef.current) {
// Check if SubNav contains current item
const currentItem = subNavRef.current.querySelector('[aria-current]')
Expand Down

0 comments on commit 5224fcb

Please sign in to comment.