Skip to content

Commit 25aae74

Browse files
jonrohanTylerJDev
jonrohan
authored and
TylerJDev
committed
Moving Label and Text to primer_react_css_modules_staff ship feature flag (#5000)
* Moving Label and Text to staff ship feature flag * Create serious-sheep-love.md * Create big-pumas-sit.md
1 parent 6941fd2 commit 25aae74

File tree

6 files changed

+42
-32
lines changed

6 files changed

+42
-32
lines changed

‎.changeset/big-pumas-sit.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
`Text` component CSS module feature flag changed to `primer_react_css_modules_staff`

‎.changeset/serious-sheep-love.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
`Label` component CSS module feature flag changed to `primer_react_css_modules_staff`

‎e2e/components/Label.test.ts‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ test.describe('Label', () => {
1414
globals: {
1515
colorScheme: theme,
1616
featureFlags: {
17-
primer_react_css_modules_team: enabled,
17+
primer_react_css_modules_staff: enabled,
1818
},
1919
},
2020
})
@@ -29,7 +29,7 @@ test.describe('Label', () => {
2929
globals: {
3030
colorScheme: theme,
3131
featureFlags: {
32-
primer_react_css_modules_team: enabled,
32+
primer_react_css_modules_staff: enabled,
3333
},
3434
},
3535
})
@@ -54,7 +54,7 @@ test.describe('Label', () => {
5454
globals: {
5555
colorScheme: theme,
5656
featureFlags: {
57-
primer_react_css_modules_team: enabled,
57+
primer_react_css_modules_staff: enabled,
5858
},
5959
},
6060
})
@@ -69,7 +69,7 @@ test.describe('Label', () => {
6969
globals: {
7070
colorScheme: theme,
7171
featureFlags: {
72-
primer_react_css_modules_team: enabled,
72+
primer_react_css_modules_staff: enabled,
7373
},
7474
},
7575
})
@@ -94,7 +94,7 @@ test.describe('Label', () => {
9494
globals: {
9595
colorScheme: theme,
9696
featureFlags: {
97-
primer_react_css_modules_team: enabled,
97+
primer_react_css_modules_staff: enabled,
9898
},
9999
},
100100
})
@@ -109,7 +109,7 @@ test.describe('Label', () => {
109109
globals: {
110110
colorScheme: theme,
111111
featureFlags: {
112-
primer_react_css_modules_team: enabled,
112+
primer_react_css_modules_staff: enabled,
113113
},
114114
},
115115
})
@@ -134,7 +134,7 @@ test.describe('Label', () => {
134134
globals: {
135135
colorScheme: theme,
136136
featureFlags: {
137-
primer_react_css_modules_team: enabled,
137+
primer_react_css_modules_staff: enabled,
138138
},
139139
},
140140
})
@@ -149,7 +149,7 @@ test.describe('Label', () => {
149149
globals: {
150150
colorScheme: theme,
151151
featureFlags: {
152-
primer_react_css_modules_team: enabled,
152+
primer_react_css_modules_staff: enabled,
153153
},
154154
},
155155
})
@@ -174,7 +174,7 @@ test.describe('Label', () => {
174174
globals: {
175175
colorScheme: theme,
176176
featureFlags: {
177-
primer_react_css_modules_team: enabled,
177+
primer_react_css_modules_staff: enabled,
178178
},
179179
},
180180
})
@@ -189,7 +189,7 @@ test.describe('Label', () => {
189189
globals: {
190190
colorScheme: theme,
191191
featureFlags: {
192-
primer_react_css_modules_team: enabled,
192+
primer_react_css_modules_staff: enabled,
193193
},
194194
},
195195
})
@@ -214,7 +214,7 @@ test.describe('Label', () => {
214214
globals: {
215215
colorScheme: theme,
216216
featureFlags: {
217-
primer_react_css_modules_team: enabled,
217+
primer_react_css_modules_staff: enabled,
218218
},
219219
},
220220
})
@@ -229,7 +229,7 @@ test.describe('Label', () => {
229229
globals: {
230230
colorScheme: theme,
231231
featureFlags: {
232-
primer_react_css_modules_team: enabled,
232+
primer_react_css_modules_staff: enabled,
233233
},
234234
},
235235
})
@@ -254,7 +254,7 @@ test.describe('Label', () => {
254254
globals: {
255255
colorScheme: theme,
256256
featureFlags: {
257-
primer_react_css_modules_team: enabled,
257+
primer_react_css_modules_staff: enabled,
258258
},
259259
},
260260
})
@@ -269,7 +269,7 @@ test.describe('Label', () => {
269269
globals: {
270270
colorScheme: theme,
271271
featureFlags: {
272-
primer_react_css_modules_team: enabled,
272+
primer_react_css_modules_staff: enabled,
273273
},
274274
},
275275
})
@@ -294,7 +294,7 @@ test.describe('Label', () => {
294294
globals: {
295295
colorScheme: theme,
296296
featureFlags: {
297-
primer_react_css_modules_team: enabled,
297+
primer_react_css_modules_staff: enabled,
298298
},
299299
},
300300
})
@@ -309,7 +309,7 @@ test.describe('Label', () => {
309309
globals: {
310310
colorScheme: theme,
311311
featureFlags: {
312-
primer_react_css_modules_team: enabled,
312+
primer_react_css_modules_staff: enabled,
313313
},
314314
},
315315
})
@@ -334,7 +334,7 @@ test.describe('Label', () => {
334334
globals: {
335335
colorScheme: theme,
336336
featureFlags: {
337-
primer_react_css_modules_team: enabled,
337+
primer_react_css_modules_staff: enabled,
338338
},
339339
},
340340
})
@@ -349,7 +349,7 @@ test.describe('Label', () => {
349349
globals: {
350350
colorScheme: theme,
351351
featureFlags: {
352-
primer_react_css_modules_team: enabled,
352+
primer_react_css_modules_staff: enabled,
353353
},
354354
},
355355
})
@@ -374,7 +374,7 @@ test.describe('Label', () => {
374374
globals: {
375375
colorScheme: theme,
376376
featureFlags: {
377-
primer_react_css_modules_team: enabled,
377+
primer_react_css_modules_staff: enabled,
378378
},
379379
},
380380
})
@@ -389,7 +389,7 @@ test.describe('Label', () => {
389389
globals: {
390390
colorScheme: theme,
391391
featureFlags: {
392-
primer_react_css_modules_team: enabled,
392+
primer_react_css_modules_staff: enabled,
393393
},
394394
},
395395
})
@@ -414,7 +414,7 @@ test.describe('Label', () => {
414414
globals: {
415415
colorScheme: theme,
416416
featureFlags: {
417-
primer_react_css_modules_team: enabled,
417+
primer_react_css_modules_staff: enabled,
418418
},
419419
},
420420
})
@@ -429,7 +429,7 @@ test.describe('Label', () => {
429429
globals: {
430430
colorScheme: theme,
431431
featureFlags: {
432-
primer_react_css_modules_team: enabled,
432+
primer_react_css_modules_staff: enabled,
433433
},
434434
},
435435
})
@@ -454,7 +454,7 @@ test.describe('Label', () => {
454454
globals: {
455455
colorScheme: theme,
456456
featureFlags: {
457-
primer_react_css_modules_team: enabled,
457+
primer_react_css_modules_staff: enabled,
458458
},
459459
},
460460
})
@@ -469,7 +469,7 @@ test.describe('Label', () => {
469469
globals: {
470470
colorScheme: theme,
471471
featureFlags: {
472-
primer_react_css_modules_team: enabled,
472+
primer_react_css_modules_staff: enabled,
473473
},
474474
},
475475
})
@@ -494,7 +494,7 @@ test.describe('Label', () => {
494494
globals: {
495495
colorScheme: theme,
496496
featureFlags: {
497-
primer_react_css_modules_team: enabled,
497+
primer_react_css_modules_staff: enabled,
498498
},
499499
},
500500
})
@@ -509,7 +509,7 @@ test.describe('Label', () => {
509509
globals: {
510510
colorScheme: theme,
511511
featureFlags: {
512-
primer_react_css_modules_team: enabled,
512+
primer_react_css_modules_staff: enabled,
513513
},
514514
},
515515
})

‎e2e/components/Text.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ test.describe('Text', () => {
4646
id: story.id,
4747
globals: {
4848
featureFlags: {
49-
primer_react_css_modules_team: true,
49+
primer_react_css_modules_staff: true,
5050
},
5151
},
5252
})
@@ -60,7 +60,7 @@ test.describe('Text', () => {
6060
id: story.id,
6161
globals: {
6262
featureFlags: {
63-
primer_react_css_modules_team: false,
63+
primer_react_css_modules_staff: false,
6464
},
6565
},
6666
})
@@ -74,7 +74,7 @@ test.describe('Text', () => {
7474
id: story.id,
7575
globals: {
7676
featureFlags: {
77-
primer_react_css_modules_team: true,
77+
primer_react_css_modules_staff: true,
7878
},
7979
},
8080
})
@@ -86,7 +86,7 @@ test.describe('Text', () => {
8686
id: story.id,
8787
globals: {
8888
featureFlags: {
89-
primer_react_css_modules_team: false,
89+
primer_react_css_modules_staff: false,
9090
},
9191
},
9292
})

‎packages/react/src/Label/Label.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ const StyledLabel = styled.span<LabelProps>`
100100
`
101101

102102
const Label = React.forwardRef(function Label({as, size = 'small', variant = 'default', className, ...rest}, ref) {
103-
const enabled = useFeatureFlag('primer_react_css_modules_team')
103+
const enabled = useFeatureFlag('primer_react_css_modules_staff')
104104
if (enabled) {
105105
const Component = as || 'span'
106106
if (rest.sx) {

‎packages/react/src/Text/Text.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const StyledText = styled.span<StyledTextProps>`
5959
`
6060

6161
const Text = forwardRef(({as: Component = 'span', className, size, weight, ...props}, forwardedRef) => {
62-
const enabled = useFeatureFlag('primer_react_css_modules_team')
62+
const enabled = useFeatureFlag('primer_react_css_modules_staff')
6363

6464
const innerRef = React.useRef<HTMLElement>(null)
6565
useRefObjectAsForwardedRef(forwardedRef, innerRef)

0 commit comments

Comments
 (0)