Skip to content

Commit 1d5e931

Browse files
jonrohanTylerJDev
authored andcommitted
Moving Heading feature flag from staff ship to ga ship (#4971)
* Moving Heading component to ga flag * Create nice-moles-know.md
1 parent f4c2a61 commit 1d5e931

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

.changeset/nice-moles-know.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
Changed Heading feature flag from `primer_react_css_modules_staff` to `primer_react_css_modules_ga`

e2e/components/Heading.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test.describe('Heading', () => {
2828
id: story.id,
2929
globals: {
3030
featureFlags: {
31-
primer_react_css_modules_staff: true,
31+
primer_react_css_modules_ga: true,
3232
},
3333
},
3434
})
@@ -51,7 +51,7 @@ test.describe('Heading', () => {
5151
id: story.id,
5252
globals: {
5353
featureFlags: {
54-
primer_react_css_modules_staff: true,
54+
primer_react_css_modules_ga: true,
5555
},
5656
},
5757
})

packages/react/src/Heading/Heading.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const StyledHeading = styled.h2<StyledHeadingProps>`
3737
`
3838

3939
const Heading = forwardRef(({as: Component = 'h2', className, variant, ...props}, forwardedRef) => {
40-
const enabled = useFeatureFlag('primer_react_css_modules_staff')
40+
const enabled = useFeatureFlag('primer_react_css_modules_ga')
4141
const innerRef = React.useRef<HTMLHeadingElement>(null)
4242
useRefObjectAsForwardedRef(forwardedRef, innerRef)
4343

packages/react/src/Heading/__tests__/Heading.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ describe('Heading', () => {
142142
).toHaveStyleRule('font-style', 'italic')
143143
})
144144

145-
describe('with primer_react_css_modules_staff enabled', () => {
145+
describe('with primer_react_css_modules_ga enabled', () => {
146146
it('should only include css modules class', () => {
147147
HTMLRender(
148148
<FeatureFlags
149149
flags={{
150-
primer_react_css_modules_staff: true,
150+
primer_react_css_modules_ga: true,
151151
}}
152152
>
153153
<Heading>test</Heading>
@@ -163,7 +163,7 @@ describe('Heading', () => {
163163
const {container} = HTMLRender(
164164
<FeatureFlags
165165
flags={{
166-
primer_react_css_modules_staff: true,
166+
primer_react_css_modules_ga: true,
167167
}}
168168
>
169169
<Heading className="test">test</Heading>
@@ -176,7 +176,7 @@ describe('Heading', () => {
176176
HTMLRender(
177177
<FeatureFlags
178178
flags={{
179-
primer_react_css_modules_staff: true,
179+
primer_react_css_modules_ga: true,
180180
}}
181181
>
182182
<Heading

0 commit comments

Comments
 (0)