Skip to content

Commit

Permalink
Merge branch 'main' into willglas-export-autocomplete-context
Browse files Browse the repository at this point in the history
  • Loading branch information
willglas authored Jun 28, 2022
2 parents 65501ad + 72266b9 commit 1a52531
Show file tree
Hide file tree
Showing 44 changed files with 1,725 additions and 117 deletions.
10 changes: 0 additions & 10 deletions .changeset/funny-hats-sing.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/modern-fireants-destroy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Adds a draft component to render a basic segmented control.
5 changes: 5 additions & 0 deletions .changeset/poor-wombats-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Adds roles of tablist and tab to the TabNav component, required rearranging the HTML elements to be semantically correct
5 changes: 5 additions & 0 deletions .changeset/rude-buckets-fold.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Converted commonjs `require` of `focus-visible` to an esm `import`
5 changes: 0 additions & 5 deletions .changeset/slimy-rabbits-try.md

This file was deleted.

29 changes: 29 additions & 0 deletions .changeset/small-donkeys-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
"@primer/react": patch
---

Deprecate SideNav in favor of [NavList](https://primer.style/NavList).

## Before

```jsx
<SideNav aria-label="Main">
<SideNav.Link href="/" selected>
Home
</SideNav.Link>
<SideNav.Link href="/about">About</SideNav.Link>
<SideNav.Link href="/contact">Contact</SideNav.Link>
</SideNav>
```

## After

```jsx
<NavList aria-label="Main">
<NavList.Item href="/" aria-current="page">
Home
</NavList.Item>
<NavList.Item href="/about">About</NavList.Item>
<NavList.Item href="/contact">Contact</NavList.Item>
</NavList>
```
5 changes: 5 additions & 0 deletions .changeset/smooth-balloons-hope.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Passthrough ActionList.Group props from NavList.Group
72 changes: 72 additions & 0 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"

on:
push:
branches: [ "main" ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ "main" ]
schedule:
- cron: '18 23 * * 5'

jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: false
matrix:
language: [ 'javascript', 'ruby' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

steps:
- name: Checkout repository
uses: actions/checkout@v3

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.

# Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
# queries: security-extended,security-and-quality


# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun

# If the Autobuild fails above, remove it and uncomment the following three lines.
# modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.

# - run: |
# echo "Run, Build Application using script"
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
6 changes: 5 additions & 1 deletion .github/workflows/deploy_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ jobs:
if: ${{ github.repository == 'primer/react' }}
name: Preview
uses: primer/.github/.github/workflows/deploy_preview.yml@main
permissions:
contents: read
pages: write
id-token: write
with:
node_version: 16
node_version: 14
install: npm ci && cd docs && npm ci && cd ..
build: npm run build:docs:preview
output_dir: docs/public
2 changes: 1 addition & 1 deletion .github/workflows/deploy_production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
if: ${{ needs.guard.outputs.should_deploy == 'true' }}
uses: primer/.github/.github/workflows/deploy.yml@main
with:
node_version: 16
node_version: 14
install: npm ci && cd docs && npm ci && cd ..
build: npm run build:docs
output_dir: docs/public
1 change: 1 addition & 0 deletions @types/focus-visible/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module 'focus-visible'
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# @primer/components

## 35.3.0

### Minor Changes

- [#2112](https://github.com/primer/react/pull/2112) [`74e1d138`](https://github.com/primer/react/commit/74e1d1386bc6bb6326c3c2b64b5e31146f9cc56b) Thanks [@colebemis](https://github.com/colebemis)! - [NavList](https://primer.style/NavList) is ready to use. You can now import it from the main bundle:

```js
import {NavList} from '@primer/react'
```

### Patch Changes

- [#2083](https://github.com/primer/react/pull/2083) [`ea69ccd6`](https://github.com/primer/react/commit/ea69ccd6b5255e70251889ffc2434e975a9c8184) Thanks [@ty-v1](https://github.com/ty-v1)! - Export new Dialog component from the `@primer/react/drafts` bundle:

```diff
- import {Dialog} from '@primer/react/lib-esm/Dialog/Dialog'
+ import {Dialog} from '@primer/react/drafts'
```

* [#2117](https://github.com/primer/react/pull/2117) [`6e3532cf`](https://github.com/primer/react/commit/6e3532cf8ca11f6edc08e101d9cea4df6a1655ce) Thanks [@dgreif](https://github.com/dgreif)! - Allow minor version updates for production dependencies

- [#2095](https://github.com/primer/react/pull/2095) [`db5e629c`](https://github.com/primer/react/commit/db5e629c667203728d4256d4b6b549b9d3962e9d) Thanks [@hectahertz](https://github.com/hectahertz)! - Communicate the SelectPanel multi-select capability to assistive technologies.

## 35.2.2

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions contributor-docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ See [`src/__tests__/example.js`](src/__tests__/example.js) for examples of ways

### TypeScript support

Primer React is written in TypeScript. We include type definitions in our built artifacts. To check types, run the `typecheck` script:
Primer React is written in TypeScript. We include type definitions in our built artifacts. To check types, run the `type-check` test script:

```
npm run typecheck
npm run test:type-check
```

### Additional resources
Expand Down
Loading

0 comments on commit 1a52531

Please sign in to comment.