Skip to content

Commit 0e744e2

Browse files
Tooltip: Take the position:absolute back and make sure the v1 and v2 ids are same for new docs (#4317)
* position absolute on the popover-open and make sure the v1 and v2 ids some for new docs * take position absolute back all together - it is only a docs issue * add changeset * update changeset * couldn't use the new changeset cli - marked the change as major! Take it back it is patch
1 parent 5d3fcd3 commit 0e744e2

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.changeset/tall-spiders-pay.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': patch
3+
---
4+
5+
Tooltip: Take position:absolute back that was introduced in https://github.com/primer/react/pull/4250 since causing flickering issues and update v2 id to be the same with v1 for the new docs site.

docs/content/TooltipV2.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
componentId: tooltip_v2
2+
componentId: tooltip
33
title: Tooltip v2
44
status: Beta
55
a11yReviewed: true

packages/react/src/TooltipV2/Tooltip.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const StyledTooltip = styled.div`
2323
/* Overriding the default popover styles */
2424
display: none;
2525
&[popover] {
26-
position: absolute;
2726
padding: 0.5em 0.75em;
2827
width: max-content;
2928
margin: auto;

0 commit comments

Comments
 (0)