From 06bdde9f6d5d15ff96ecdc1163dfe9819f315b11 Mon Sep 17 00:00:00 2001
From: Clay Miller <clay@smockle.com>
Date: Wed, 23 Jun 2021 13:06:31 -0400
Subject: [PATCH] fix: Type 'DropdownButton' as 'button' (#1318)

* fix: Type 'DropdownButton' as 'button'

* chore: Update snapshots
---
 src/DropdownMenu/DropdownButton.tsx               | 2 +-
 src/__tests__/__snapshots__/DropdownMenu.tsx.snap | 1 +
 src/__tests__/__snapshots__/SelectPanel.tsx.snap  | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/DropdownMenu/DropdownButton.tsx b/src/DropdownMenu/DropdownButton.tsx
index df2a7f36d87..450e6133429 100644
--- a/src/DropdownMenu/DropdownButton.tsx
+++ b/src/DropdownMenu/DropdownButton.tsx
@@ -7,7 +7,7 @@ export type DropdownButtonProps = ButtonProps
 
 export const DropdownButton = React.forwardRef<HTMLElement, React.PropsWithChildren<DropdownButtonProps>>(
   ({children, ...props}: React.PropsWithChildren<DropdownButtonProps>, ref): JSX.Element => (
-    <Button ref={ref} {...props}>
+    <Button ref={ref} type="button" {...props}>
       {children}
       <StyledOcticon icon={TriangleDownIcon} ml={1} />
     </Button>
diff --git a/src/__tests__/__snapshots__/DropdownMenu.tsx.snap b/src/__tests__/__snapshots__/DropdownMenu.tsx.snap
index 0e1fd83dd83..ff413f760bd 100644
--- a/src/__tests__/__snapshots__/DropdownMenu.tsx.snap
+++ b/src/__tests__/__snapshots__/DropdownMenu.tsx.snap
@@ -79,6 +79,7 @@ exports[`DropdownMenu renders consistently 1`] = `
   onClick={[Function]}
   onKeyDown={[Function]}
   tabIndex={0}
+  type="button"
 >
   <svg
     aria-hidden="true"
diff --git a/src/__tests__/__snapshots__/SelectPanel.tsx.snap b/src/__tests__/__snapshots__/SelectPanel.tsx.snap
index ca231625b02..231134b2db0 100644
--- a/src/__tests__/__snapshots__/SelectPanel.tsx.snap
+++ b/src/__tests__/__snapshots__/SelectPanel.tsx.snap
@@ -91,6 +91,7 @@ exports[`SelectPanel renders consistently 1`] = `
     onClick={[Function]}
     onKeyDown={[Function]}
     tabIndex={0}
+    type="button"
   >
     Select Items
     <svg