-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
907 accept additional props for labeling icons #932
907 accept additional props for labeling icons #932
Conversation
🦋 Changeset detectedLatest commit: 6f4fa1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Left some quick comments on this, curious what you think 👀
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Co-authored-by: Josh Black <joshblack@github.com>
…ub.com:primer/octicons into 907-accept-additional-props-for-labeling-icons
Co-authored-by: Josh Black <joshblack@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🥳 When you get a sec, could you merge in main
? Would love to see what it looks like with some of the ref
changes that came up in latest. Left a couple comments and questions too, let me know what you think!
…-props-for-labeling-icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! Just left one comment for the README, seems like there are still diff markers there but otherwise should be good to go!
Co-authored-by: Josh Black <joshblack@github.com>
No description provided.