Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

907 accept additional props for labeling icons #932

Merged
merged 19 commits into from
May 25, 2023

Conversation

green6erry
Copy link
Contributor

No description provided.

@green6erry green6erry linked an issue Mar 15, 2023 that may be closed by this pull request
2 tasks
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 6f4fa1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left some quick comments on this, curious what you think 👀

lib/octicons_react/src/index.d.ts Show resolved Hide resolved
lib/octicons_react/src/index.d.ts Outdated Show resolved Hide resolved
lib/octicons_react/src/index.d.ts Outdated Show resolved Hide resolved
lib/octicons_react/src/index.d.ts Show resolved Hide resolved
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 15, 2023
@green6erry green6erry marked this pull request as ready for review May 15, 2023 20:20
@green6erry green6erry requested a review from a team as a code owner May 15, 2023 20:20
@green6erry green6erry requested a review from colebemis May 15, 2023 20:20
green6erry and others added 4 commits May 15, 2023 16:20
Co-authored-by: Josh Black <joshblack@github.com>
…ub.com:primer/octicons into 907-accept-additional-props-for-labeling-icons
Co-authored-by: Josh Black <joshblack@github.com>
@green6erry green6erry requested a review from joshblack May 17, 2023 18:44
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🥳 When you get a sec, could you merge in main? Would love to see what it looks like with some of the ref changes that came up in latest. Left a couple comments and questions too, let me know what you think!

lib/octicons_react/src/createIconComponent.js Outdated Show resolved Hide resolved
lib/octicons_react/src/index.d.ts Outdated Show resolved Hide resolved
lib/octicons_react/src/createIconComponent.js Outdated Show resolved Hide resolved
lib/octicons_react/README.md Show resolved Hide resolved
lib/octicons_react/README.md Show resolved Hide resolved
lib/octicons_react/README.md Outdated Show resolved Hide resolved
lib/octicons_react/README.md Outdated Show resolved Hide resolved
lib/octicons_react/README.md Show resolved Hide resolved
@green6erry green6erry requested a review from joshblack May 17, 2023 21:47
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Just left one comment for the README, seems like there are still diff markers there but otherwise should be good to go!

lib/octicons_react/README.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Black <joshblack@github.com>
@colebemis colebemis merged commit ea81ec1 into main May 25, 2023
@colebemis colebemis deleted the 907-accept-additional-props-for-labeling-icons branch May 25, 2023 17:59
@primer-css primer-css mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept additional props for labeling icons
3 participants