Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Website icons not in sync with release tag #738

Closed
geoffreymcgill opened this issue Feb 5, 2022 · 3 comments
Closed

[Bug] Website icons not in sync with release tag #738

geoffreymcgill opened this issue Feb 5, 2022 · 3 comments
Assignees

Comments

@geoffreymcgill
Copy link

The v16.3.0 icons published on the website are not in sync with the v16.3.0 release tag.

Screen Shot 2022-02-05 at 1 45 52 PM

For example, see the upload icon on the website:

Screen Shot 2022-02-05 at 1 51 30 PM

... and here is the upload icon in the main branch:

Screen Shot 2022-02-05 at 2 02 46 PM

... vs the upload icon in the v16.3.0 release tag:

Screen Shot 2022-02-05 at 1 52 15 PM

@ashygee
Copy link
Contributor

ashygee commented Feb 7, 2022

Hi @geoffreymcgill, because we are using changesets to cut releases we have PRs automatically created for our release tracking. The updated upload icon will be in 16.3.1 as seen in this PR. #735

@ashygee ashygee closed this as completed Feb 7, 2022
@fabriciomurta
Copy link

Ashygee, I think you have the website publish workflow set for every push instead of every "release publish". So once the pull request for the upload icon was merged, the new icon reflected in the website while reporting version 16.3.0.

Now that release 16.3.1 occurred, the website is up-to-date (has 16.3.1 changes and report version 16.3.1). So I guess it is pushing a "latest" version before the version number is actually switched and, when the version string is bumped (with the release) the "push" with the version changes trigger again deployment and the site stays in sync with the reported version... until next pull request is merged. :)

In other words, the way the deploy is set up now will reflect current main in the website while reporting the latest full release version string, which made us some confusion about the upload icon and version it was included in.

@geoffreymcgill
Copy link
Author

The original issue will still happen and is a valid issue. Please consider re-opening.

At the time, the website was sync'd with main (the next release?) and not the latest Release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants