Skip to content

Disabled elements are not interactive and add this to the rule (Tooltip) #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jul 26, 2023

Closes #60

  • Add a check to the tooltip interactive trigger rule to exclude elements that have disabled attribute (reference)
  • Did also some tiny refactors and renames

Note: I didn't add changeset because the rule hasn't been released yet and it can go within the same changeset

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 49abff7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup changed the title Disabled elements are not interactive and add this to the rule Disabled elements are not interactive and add this to the rule (Tooltip) Jul 26, 2023
@TylerJDev TylerJDev mentioned this pull request Jul 26, 2023
@broccolinisoup broccolinisoup merged commit e008dbc into main Jul 27, 2023
@broccolinisoup broccolinisoup deleted the bs/disabled-check branch July 27, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the a11y-tooltip-interactive-trigger to exclude elements that have disabled attribute from the interactive element list
2 participants