Skip to content

Update no-deprecated-experimental-components.js #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Apr 24, 2025

Updates message for no-deprecated-experimental-components rule

@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 17:31
@francinelucca francinelucca requested a review from a team as a code owner April 24, 2025 17:31
@francinelucca francinelucca requested a review from jonrohan April 24, 2025 17:31
Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: efa3341

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the error message in the no-deprecated-experimental-components rule to provide clearer guidance for developers.

  • Updated error message to reference migration guides and alternative component sources.
  • Revised messaging to encourage importing from the stable entrypoint (@primer/react).
Comments suppressed due to low confidence (1)

src/rules/no-deprecated-experimental-components.js:58

  • [nitpick] The updated error message now includes detailed migration guidance and an alternative components URL. Consider ensuring that the tone and sentence structure remain consistent with other rule messages in the codebase.
} deprecated. Please import from the stable entrypoint (@primer/react) if available. Check https://primer.style/product/getting-started/react/migration-guides/ for migration guidance or https://primer.style/product/components/ for alternative components.`

Copy link
Member

@lesliecdubs lesliecdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration on the messaging

@francinelucca francinelucca merged commit c709c98 into main Apr 24, 2025
9 checks passed
@francinelucca francinelucca deleted the francinelucca-patch-1 branch April 24, 2025 17:44
@primer-css primer-css mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants