Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-wildcard-imports): support test-helpers, mix-and-match imports #242

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 24, 2024

Update our no-wildcard-import rule to work in the following scenarios:

  • When someone imports from @primer/react/lib-esm/utils/test-helpers
  • When someone uses both type and value imports in a single import statement

@joshblack joshblack requested a review from a team as a code owner September 24, 2024 21:33
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 2d99a97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack merged commit e139c02 into main Oct 7, 2024
8 checks passed
@joshblack joshblack deleted the fix/update-no-wildcard-imports-duplication branch October 7, 2024 15:33
@primer-css primer-css mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants